Closed Bug 606483 Opened 13 years ago Closed 13 years ago

Pixastic desaturate test no longer traces with jit profiling

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: billm)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: regression, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

patch
3.52 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
I really wish we had actual performance regression tests for this stuff...

This benchmark has a single loop, the loop iterates for a bajillion (4096000) iterations, and the loop body is:

   data[pix-=4] = data[pix1=pix+1] = data[pix2=pix+2] =
                  (data[pix]+data[pix1]+data[pix2])/3

This seems like the canonical tracing use-case to me...
Comment on attachment 485347 [details] [diff] [review]
patch

This seems to fix the problem by giving the tracer priority for typed arrays.
Attachment #485347 - Flags: review?(bzbarsky)
Comment on attachment 485347 [details] [diff] [review]
patch

r=me.  Looks great.
Attachment #485347 - Flags: review?(bzbarsky) → review+
Assignee: general → wmccloskey
http://hg.mozilla.org/mozilla-central/rev/22ddfe328264
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Blocks: 467263
You need to log in before you can comment on or make changes to this bug.