606553 - We use a write barrier on memory that doesn't contain pointers

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Tommy Reilly]

Attachment: fix it

Silliness, found by new stricter write barrier assertions.

Comment 1

[Tommy Reilly]

Adding new assertions to write barriers as part of bug 525875 and learning some interesting things.

Comment 2

[Tommy Reilly]

This would be nice to have: https://bugzilla.mozilla.org/show_bug.cgi?id=606559

Comment 3

[Lars T Hansen]

Comment on attachment 485357 [details] [diff] [review]
fix it

In the absence of WB_SKIP - which seems like a fine idea - there probably ought to be a comment in each instance, eg, "// No WB necessary as the container is non-pointer-containing".  (I'm just looking at the patch, so assume I don't know what I'm talking about if there are comments to the same effect in the immediate vicinity.)  Assume SR+ with that change.

Comment 4

[Tommy Reilly]

http://hg.mozilla.org/tamarin-redux/rev/d0f713628f77

Comment 5

[Tommy Reilly]

I went with a stubbed out WB_SKIP macro to at least establish a precedent and make it clear what's going on and added a comment to the top of the function that builds the list.