Closed
Bug 606567
Opened 15 years ago
Closed 15 years ago
Intermittent failure in browser/base/content/test/browser_bug585785.js | tab successfully removed
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
People
(Reporter: jdm, Assigned: dao)
References
Details
(Keywords: intermittent-failure)
Attachments
(2 files, 1 obsolete file)
|
854 bytes,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
|
1.70 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1287776477.1287778465.29636.gz
Rev3 Fedora 12x64 mozilla-central debug test mochitest-other on 2010/10/22 12:41:17
s: talos-r3-fed64-022
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bug585785.js | tab successfully removed
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bug585785.js | Found an unexpected tab at the end of test run: about:blank
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Assignee | ||
Updated•15 years ago
|
Assignee: nobody → dao
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 7•15 years ago
|
||
Looks like the test's executeSoon is racing with the start of the animation...
| Assignee | ||
Comment 8•15 years ago
|
||
This should reliably put the removeTab call right before the first animation frame.
Attachment #485573 -
Flags: review?(gavin.sharp)
| Assignee | ||
Comment 9•15 years ago
|
||
Comment on attachment 485573 [details] [diff] [review]
patch
>+ if (!tab.getAttribute("fadein") == "true") {
>+ return;
>+ window.mozRequestAnimationFrame();
Err, this is wrong...
Attachment #485573 -
Attachment is obsolete: true
Attachment #485573 -
Flags: review?(gavin.sharp)
| Assignee | ||
Comment 10•15 years ago
|
||
Attachment #485574 -
Flags: review?(gavin.sharp)
Updated•15 years ago
|
Attachment #485574 -
Flags: review?(gavin.sharp) → review+
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Assignee | ||
Comment 12•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Assignee | ||
Updated•15 years ago
|
Status: RESOLVED → REOPENED
OS: Linux → Mac OS X
Resolution: FIXED → ---
| Assignee | ||
Comment 15•15 years ago
|
||
restored executeSoon: http://hg.mozilla.org/mozilla-central/rev/b3bc32ff0612
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Assignee | ||
Comment 17•15 years ago
|
||
It appears that the frame needed to expose the bug just isn't rendered under heavy load. So this just confirms that the tab closes *somehow*.
Attachment #485749 -
Flags: review?(gavin.sharp)
Updated•15 years ago
|
Attachment #485749 -
Flags: review?(gavin.sharp) → review+
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Assignee | ||
Comment 27•15 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Updated•13 years ago
|
Keywords: intermittent-failure
Updated•13 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•