606626 - JM: Comment which stubCall is being invoked

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, enhancement)

Description

[Steve Fink [:sfink] [:s:]]

Attachment: Make stubCall spew the name of the stub being called

I've been digging into JM recently, and I added some nasty macro gunk to enhance the JMFLAGS dumping output with the names of stubCalls being invoked.

Before:
  [jaeger] Insns     ---- CALLING STUB ----
After:
  [jaeger] Insns        - CALLING STUB stubs::EnterScript -

Would something like this (done properly) be of interest to anyone else? It turned out to not be particularly helpful for what I was looking at, but it seems like it ought to be useful for something.

If people are interested, I could try cleaning this up.

Comment 1

[David Mandelin [:dmandelin]]

I haven't looked at the insns spew much lately, so I suspect it would not be used by too many people. But maybe someone else does use it.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

(In reply to comment #1)
> I haven't looked at the insns spew much lately, so I suspect it would not be
> used by too many people. But maybe someone else does use it.

I tend to look at it fairly often. I think it would be useful.

Comment 3

[Sean Stangl [:sstangl]]

Can't hurt. If you think it improves ease of comprehension, I'm all for it.

Comment 4

[Ryan VanderMeulen (PTO, back July 27)]

Is this still wanted?

Comment 5

[Steve Fink [:sfink] [:s:]]

I'm not going to bother with it at this point. If someone else finds it useful enough, they can reopen.