javascript strict warnings in pref-search.js

VERIFIED FIXED

Status

SeaMonkey
Preferences
P3
normal
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: Henrik Gemal, Assigned: matt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
JavaScript strict warning:
chrome://communicator/content/pref/pref-search.js line 59: redeclaration of var
defaultEngineURI

Comment 1

17 years ago
Created attachment 21820 [details] [diff] [review]
proposed patch

Updated

17 years ago
Keywords: patch

Comment 2

17 years ago
Looking at this again, i noticed that InitSingleEngineList() and
setDefaultSearchEngine() are unused.  Attaching a patch that removes those
obsolete functions and some other dead code. Adding jag for r=
Keywords: review

Comment 3

17 years ago
Created attachment 22138 [details] [diff] [review]
patch - more agressive cleanup

Comment 4

17 years ago
r=timeless :-)
Keywords: review → approval

Comment 5

17 years ago
cc'ing alec for sr

Comment 6

17 years ago
 * Contributor(s): Robert John Churchill (rjc@netscape.com)
 *                 Mark Olson (maolson@earthlink.net)

I believe the preferred way to write this is:

 * Contributor(s):
 *   Robert John Churchill <rjc@netscape.com>
 *   Mark Olson <maolson@earthlink.net>

Optionally with "(Original Author)" appended to the deserving name :-)

No need to attach a new patch, but could whoever ends up checking this in (I'm
sure someone will beat me to it) fix that?
a=ben@netscape.com

Comment 8

17 years ago
fix checked in
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Keywords: approval, patch
Resolution: --- → FIXED
(Reporter)

Comment 9

17 years ago
I cant see the warnings with todays build 20010619.
Will reopen if I see them again.

Please add the following line to your prefs.js file, so we could avoid all 
these strict warning fixup...:
user_pref("javascript.options.strict", true);
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.