60669 - javascript strict warnings in EdDialogCommon.js

Status: VERIFIED WORKSFORME

(Core :: DOM: Editor, defect, P3)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://editor/content/EdDialogCommon.js line 993: reference to undefined prope
rty colors.TextColor

JavaScript strict warning:
chrome://editor/content/EdDialogCommon.js line 996: reference to undefined prope
rty colors.BackgroundColor

Comment 1

[Fabian Guisset]

How do you reproduce this one?

Comment 2

[Henrik Gemal]

Add:
user_pref("javascript.options.strict", true);
to your prefs.js file and go into Preferences -> New Page Settings

Comment 3

[rubydoo123]

assigning to cmanske -- his code

Comment 4

[Charles Manske]

Extremely minor. We are testing for the existence of a couple of variables that
may be null like this:
if (!color.TextColor)
  color.TextColor = ...
so there's really nothing wrong with the code.
The warnings can be avoided by simply initiallizing color.TextColor and
color.BackgroundColor to 0.

Comment 5

[Charles Manske]

Variables are initialized to avoid JS warning.

Comment 6

[Mark Olson]

Verified Linux 20010106

Comment 7

[Henrik Gemal]

sorry to say but:

Warning: assignment to undeclared variable metaElement
Source File: chrome://editor/content/EdDialogCommon.js
Line: 970

Comment 8

[Henrik Gemal]

also:
Warning: assignment to undeclared variable metaElement
Source File: chrome://editor/content/EdDialogCommon.js
Line: 1003

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Fix, declares metaElement

Comment 10

[Henrik Gemal]

I see:

Warning: assignment to undeclared variable nextChild
Source File: chrome://editor/content/EdDialogCommon.js
Line: 613

Warning: assignment to undeclared variable metaElement
Source File: chrome://editor/content/EdDialogCommon.js
Line: 970

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

Attachment: new fix, declares metaElement and nextChild

Comment 12

[Henrik Gemal]

r=[e-mail]

Comment 13

[kinmoz]

sr=[e-mail] for 07/24/01 01:11 patch

Comment 14

[[e-mail] (gone - use [e-mail] instead)]

Fix checked in, thanks to all.

Comment 15

[Henrik Gemal]

Verified! Warnings seems gone to me. Will reopen if found again...
Build 20010820 on win2k

Comment 16

[Henrik Gemal]

going into Edit -> Prefs -> Composer -> New Page Settings produces:
Warning: function ConfirmWithTitle does not always return a value
Source File: chrome://editor/content/EdDialogCommon.js
Line: 288
Source Code:
}

Comment 17

[Charles Manske]

I'm not seeing anymore warnings. I examined "ConfirmWithTitle" and it looks good.

Comment 18

[sujay]

verified.