As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 606727 - _handleNewTab should only be called once even if a tab's max-width is later modified
: _handleNewTab should only be called once even if a tab's max-width is later m...
[fixed by bug 465086]
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 5
Assigned To: Frank Yan (:fryn)
: Dão Gottwald [:dao]
Depends on: 465086 622266
  Show dependency treegraph
Reported: 2010-10-23 17:24 PDT by ithinc
Modified: 2013-11-13 02:20 PST (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Description User image ithinc 2010-10-23 17:24:25 PDT
User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101023 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101023 Firefox/4.0b8pre

When implementing a "don't resize tabs until mouse leaves the tab bar when closing tabs repeatedly" feature, I need to change the max-width of the remaining tabs programmaticly. Then I find the tab animation will lead to some unwanted behavior. gBrowser.mTabContainer._handleNewTab is unnecessarily invoked after the transition end of max-width.

In tabbrowser.xml:
      <handler event="transitionend"><![CDATA[
        if (event.propertyName != "max-width")

        var tab =;

        if (tab.getAttribute("fadein") == "true")
        else if (this.tabbrowser._removingTabs.indexOf(tab) > -1)

The tab with a "fadein" attribute is not necessarily a New Tab when transitionend event happens.

Reproducible: Always

Expected Results:  
We set a "fading" attribute when a new tab is created, and remove it after the transition ends.
Comment 1 User image Alice0775 White 2010-10-23 18:52:05 PDT
Maybe duplicate of Bug 465086?
Comment 2 User image ithinc 2010-10-23 22:47:24 PDT
(In reply to comment #1)
> Maybe duplicate of Bug 465086?
Thanks for letting me know of this one, but not exactly. I'm not requesting a feature, but pointing out a bug.
Comment 3 User image Frank Yan (:fryn) 2011-04-09 00:50:01 PDT
The patch in bug 465086 fixes this by checking the property mFullyOpen on the tab at the beginning of _handleNewTab().

I'll resolve this bug if/when that lands.

Note You need to log in before you can comment on or make changes to this bug.