60678 - Autocompletion seems to be "reset" after a % (percent) char

Status: VERIFIED WORKSFORME

(SeaMonkey :: UI Design, defect, P3)

Description

[Tomas Ögren]

If you have visited "http://www.a.b"  and "http://www.d.e" and then start typing
"http://www.foo.bar/%http://w" then it will autocomplete to
"http://www.foo.bar/%http://www.a.b" and "http://www.foo.bar/%http://www.d.e"
which isn't in the history. Seems like it ignores everything before a %
Tested with nightly as of 2000-11-19

Comment 1

[Boris Zbarsky [:bzbarsky]]

The % char is not needed, even.  It's reset upon encountering a double backslash.

Looking at the autocomplete code, this seems to be due to an rfind being used to
look for "//" instead of the expected "lfind"

I'm not sure whether this is a bug or a design decision...

Over to XP apps, since Autofill does not include URL bar completion.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Er, correction.  I meant "double forward slash" in my previous comment.

Sorry for the spam... :(

Comment 3

[sairuh (rarely reading bugmail)]

-> ducarroz for autocompletion [but reassign if needed].

Comment 4

[Keyser Sose]

I am seeing this on:
Platform: PC
OS: Win 98
Build: Mozilla Build 2000112704 M18 Trunk Build

Marking as NEW.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: patch replacing RFind with Find in two places

Comment 6

[Boris Zbarsky [:bzbarsky]]

Adding some keywords

Comment 7

[Jean-Francois Ducarroz]

Reassign to Radha.

Comment 8

[Radha on family leave (not reading bugmail)]

Attachment: urlbar History cleanup that also fixes this bug

Comment 9

[Bill Law]

r=law, with some minor comments emailed to Radha re: avoiding use of
nsCRT::free() calls.

Comment 10

[Paul Chen]

nav triage team:

Check the patch in! Marking nsbeta1, mozilla0.9, reassigning to alecf

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This dosn't really apply to this bug but I think it applies to the proposed 
patch:

IE's autocomplete searches all *visited* url's rather than all *typed* urls 
which IMHO is better. This would simplify the protocol stripping since all 
visited url's starts with a protocol...

Also it would be nice if the resultset contained:

http://www.mozilla.org/
http://www.mozilla.org/projects/
http://www.mozilla.org/projects/xpcom/
http://www.mozilla.org/projects/xpcom/XPCOM_plans.html

after visiting http://www.mozilla.org/projects/xpcom/XPCOM_plans.html.

Comment 12

[Alec Flett]

radha fixed this

Comment 13

[Chad Austin]

Lots of verifications.

If I had to test stuff, it was on Win2K, build id 2001052404.