middlemouse.openNewWindow is ignored

RESOLVED WONTFIX

Status

()

Firefox
Preferences
RESOLVED WONTFIX
8 years ago
6 years ago

People

(Reporter: Adam Sloboda, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
User-Agent:       Opera/9.80 (X11; Linux x86_64; U; en) Presto/2.6.37 Version/10.70
Build Identifier: 3.6.11 and 4.0b7pre

I am used to pasting links from X selection with middle click.  This is configured by "middlemouse.contentLoadURL;true" but when I set "middlemouse.openNewWindow;true" it is ignored and Firefox still loads URL in current tab.

Tested on Debian 3.6.11 version and 4.0b7pre.

Reproducible: Always

Steps to Reproduce:
1. middlemouse.contentLoadURL;true
2. middlemouse.openNewWindow;true
3. select any URL
4. middle click somewhere in page
Actual Results:  
URL is loaded in current tab.

Expected Results:  
URL is loaded in new tab.
(Reporter)

Comment 1

8 years ago
I have found that this event results in whereToOpenLink( e, ignoreButton, ignoreAlt ) returning "current".

I think it's missing something like this before resorting to "current":

else (ignoreButton && getBoolPref("middlemouse.openNewWindow", true)) {
  return "window";
}
(Reporter)

Comment 2

8 years ago
Created attachment 485601 [details] [diff] [review]
fix
(Reporter)

Comment 3

8 years ago
It fixes this bug alright but disrupts creation of new tabs, it's not specific enough...
(Reporter)

Comment 4

8 years ago
More info: this patch is somehow incompatible with Tab Utilities extension.  I don't understand why, yet.
(Reporter)

Comment 5

8 years ago
Works ok in clean profile.  I consider this fixed by the above patch.

Just for the record, Tabberwocky didn't suffer from any bugs so something in Tab Utilities was corrupted (didn't work with unpatched version too).
(Reporter)

Updated

7 years ago
OS: Linux → All
Version: unspecified → Trunk
(Reporter)

Comment 6

6 years ago
Created attachment 636179 [details] [diff] [review]
update for more recent firefox versions
Attachment #485601 - Attachment is obsolete: true
Comment on attachment 636179 [details] [diff] [review]
update for more recent firefox versions

You have to request review from someone specific or patches tend to get ignored.
Trying gavin for feedback
Attachment #636179 - Flags: feedback?(gavin.sharp)
This middlemouse.openNewWindow pref appears to be a SeaMonkey pref - as you noticed we've never supported it. I'm not enthused by the idea of adding support for yet another hidden pref, and this particular behavior doesn't seem widely desired. I'd recommend writing an add-on to implement this behavior, which should be relatively straightforward.

Thanks for taking the time to write a patch, though, that's pretty awesome. There are lots of other bugs to fix if you're interested :)
Status: UNCONFIRMED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
Attachment #636179 - Flags: feedback?(gavin.sharp) → feedback-
You need to log in before you can comment on or make changes to this bug.