606827 - Released and collapsing drag regions fade back into... somewhere

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P5)

Description

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Video of the current animation (webm)

When we drag out a region but it's too small so it collapses, it animates like it's fading back to where it came from... but in many cases, that "somewhere" seems to be some weird origin.

I propose to make it collapse into itself... into the center of the region.

Aza, is this the right spec?

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch v1

Comment 2

[Ian Gilman [:iangilman]]

Comment on attachment 485622 [details] [diff] [review]
Patch v1

Nice catch! All you needed to do was switch the x and y, but this version is cleaner anyway. 

I'm not in favor of speeding up the animation though... it's already fast enough that you might not get what's happening, and it's not the sort of animation that blocks user action, so there's no real need for it to be fast.

Comment 3

[Michael Yoshitaka Erlewine [:mitcho]]

> I'm not in favor of speeding up the animation though... it's already fast
> enough that you might not get what's happening, and it's not the sort of
> animation that blocks user action, so there's no real need for it to be fast.

Aza, thoughts?

Comment 4

[Aza Raskin [:aza]]

Agreed. I think the speed is right at the moment and indeed the group should collapse into itself.

Comment 5

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch v2, reverted animation speed

Comment 6

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

Comment 7

[Ian Gilman [:iangilman]]

Does it need a try run?

Comment 8

[Ian Gilman [:iangilman]]

(In reply to comment #7)
> Does it need a try run?

Mitcho?

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/18864f1a6b42