606970 - Add-ons manager completely broken (No add-ons visible)

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101024 Firefox/4.0b8pre

Today while verifying some fixes for AOM and ACR I had to switch between different branches of Firefox. Some minutes ago I have noticed that my complete testing profile is broken. There are dozen of errors shown in the error console which clearly state that we have problems with the database.

I will attach the complete testing profile so it should be able to reproduce.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Testing profile

Comment 2

[Dave Townsend [:mossop]]

Without a way to reproduce this it is going to be difficult to figure out the code error that caused it, however the resulting problem will be fixed by bug 602577

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Well, I know. But I wasn't able to corrupt the profile again. I will report back when I have more information at some point.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks like the database has not been corrupted:

> sqlite> PRAGMA integrity_check;
> ok

Comment 5

[Dave Townsend [:mossop]]

No, it just has the wrong schema

Comment 6

[Dave Townsend [:mossop]]

Without a confirmed way to reproduce this specific case, and since we are blocking on a bug that will effectively fix the resulting brokenness I don't think we should block on this.

Comment 7

[Dave Townsend [:mossop]]

With bug 602577 fixed we should recover from problems like this. It would be nice to find out what causes the problem in the first place but until we do there isn't really anything more to do here.

Comment 8

[Dave Townsend [:mossop]]

Backed out due to test failures

Comment 9

[Dave Townsend [:mossop]]

And relanded

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The patch on bug 602577 fixed the particular problem with my broken profile. Marking as verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101111 Firefox/4.0b8pre