If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

window.sidebar.addPanel has stopped functioning for bookmarking via javascript

RESOLVED INVALID

Status

()

Firefox
General
--
major
RESOLVED INVALID
7 years ago
4 years ago

People

(Reporter: andykillen, Unassigned)

Tracking

3.6 Branch
x86
Windows Vista
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US) AppleWebKit/534.10 (KHTML, like Gecko) Chrome/8.0.552.11 Safari/534.10
Build Identifier: 3.6.11

I make a wordpress plugin (share and follow) that has many users reporting to me that the window.sidebar.addPanel(title, url,"") element of the bookmarking has stopped funcitoning properly in Firefox. 

I've tested this substantially and re-checked the code that was working only 2 weeks ago and have found the same problem as them. Please see the link and click on the "star" bookmark button under the post. 

What happens when you click on it is that it tries to bookmark the physical content of the HREF='' and not the javascript response that should take up that space.  

i.e.  actual code on page for location
javascript:window.bookMark('http%3A%2F%2Fshare-and-follow.com%2Fwordpress-plugin%2F2010%2F10%2Fversion-1-50-now-out-cdn-extra-icon-sets-more-social-networks-massive-change-in-code-its-halloween%2F',%20'Version+1.50+now+out.+CDN%2C+extra+icon+sets%2C+more+social+networks%2C+massive+change+in+code%E2%80%A6+it%E2%80%99s+Halloween%21',%20BrowserDetect.browser);

bookMark() runs this code 
 window.sidebar.addPanel(thetitle, theurl,"");

BrowserDetect.browser() just reports back what browser such as Firefox

Wanted response in the location when clicking the button is 

http%3A%2F%2Fshare-and-follow.com%2Fwordpress-plugin%2F2010%2F10%2Fversion-1-50-now-out-cdn-extra-icon-sets-more-social-networks-massive-change-in-code-its-halloween%2F






Reproducible: Always

Steps to Reproduce:
1. goto URL
2. click "star"  bookmark button under post
3. Look at location in the browser popup much for bookmarking
Actual Results:  
javascript:window.bookMark('http%3A%2F%2Fshare-and-follow.com%2Fwordpress-plugin%2F2010%2F10%2Fversion-1-50-now-out-cdn-extra-icon-sets-more-social-networks-massive-change-in-code-its-halloween%2F',%20'Version+1.50+now+out.+CDN%2C+extra+icon+sets%2C+more+social+networks%2C+massive+change+in+code%E2%80%A6+it%E2%80%99s+Halloween%21',%20BrowserDetect.browser);

Expected Results:  
http%3A%2F%2Fshare-and-follow.com%2Fwordpress-plugin%2F2010%2F10%2Fversion-1-50-now-out-cdn-extra-icon-sets-more-social-networks-massive-change-in-code-its-halloween%2F

I have had reports from 3 users of my plugin so far.  I cannot say what version of firefox they use.  This will effect every website/page that has javascript browser bookmarking for firefox

Comment 1

7 years ago
Firefox3.0.x, Firefox3.5.x and Firefox3.6.x are same behavior.

Remove rel attribute from a tag, then the link works as expected. 
So, I guess that contents of the page was changed by the administrator of the site.

Comment 2

7 years ago
this should work on Firefox:
<a rel="sidebar" href="http://example.com/" title="example">bookmark</a>
or
<a href="javascript:window.sidebar.addPanel('example','http://example.com/','')" title="example">bookmark</a>

Updated

7 years ago
Version: unspecified → 3.6 Branch

Comment 3

4 years ago
Bug 691647 removed addPanel.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.