607005 - xpcshell-tests: test_bug_401430.js should report an actual check

Status: RESOLVED WORKSFORME

(Toolkit :: Downloads API, defect)

Description

[Serge Gautherie (:sgautherie)]

Bug 450807 "replaced" a do_check_true() with a print().

Now the test logs
"TEST-INFO | (xpcshell/head.js) | No (+ 0) checks actually run".

A do_check_true(true) should be added, or even replace the print()...

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Serge, I looked around in the unit test files but didn't see this in test_bug_401430.js or any nearby files. But maybe I'm missing something. Would you mind double checking to make sure this bug is still valid? Thanks!

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to Liz Henry :lizzard from comment #1)

Code change was:
http://hg.mozilla.org/mozilla-central/rev/23d4e625a481
{{
    1.22 -  do_check_true(checkRecentDocsFor(resultFileName));

    1.38 +    print("Document found in RecentDocs");
}}

Iirc, the detailed test log should be in test_bug_401430.log (and/or the console) after running this test.

I had a quick glance at the current test code and I assume this bug is still (fully) valid.

Comment 3

[Jeffrey Tran]

I ran "./mach xpcshell-test" in my local mozilla-central directory and I see the output:

13:51.65 LOG: Thread-5601 INFO (xpcshell/head.js) | test MAIN run_test pending (1)
13:51.65 LOG: Thread-5601 INFO (xpcshell/head.js) | test pending (2)
13:51.65 LOG: Thread-5601 INFO (xpcshell/head.js) | test MAIN run_test finished (2)

I don't see the output specified in the description. So does this bug still exist or did I run the test incorrectly?

Comment 4

[Mark Banner (:standard8)]

The test was removed in bug 1253585, so this bug no longer applies.