Closed Bug 60707 Opened 23 years ago Closed 20 years ago

Right button has a same function as left button in filepicker dialog

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: kazhik, Assigned: bryner)

Details

Attachments

(1 file, 1 obsolete file)

patch v2
537 bytes, patch
bryner
: review+
bryner
: superreview+
Details | Diff | Splinter Review 
Right button has a same function as left button in filepicker dialog([File] -
[Open File]).
You can change directory by double-clicking right button.
bryner?
Assignee: trudelle → bryner
Severity: normal → minor
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
why is this a problem? what should the right button do instead?
Attached patch patch (obsolete) — — Splinter Review 
Disables right-doubleclick.

This bug is the same as bug 74799.
Attachment #75458 - Flags: review?(sspitzer)
Comment on attachment 75458 [details] [diff] [review]
patch

r=sspitzer

but I'd suggest adding the comment, like we did in mailnews

// we only care about button 0 (left click) events
Attachment #75458 - Flags: review?(sspitzer) → review+
Attached patch patch v2 — — Splinter Review 

        Attachment #75458 -
        Attachment is obsolete: true

    
  

        Attachment #115803 -
        Attachment filename: 450.diff → 60707.diff

        Attachment #115803 -
        Flags: superreview?(bryner)

    
    

    
  
Comment on attachment 115803 [details] [diff] [review]
patch v2

sr=me, carrying over sspitzer's r=.

        Attachment #115803 -
        Flags: superreview?(bryner)

        Attachment #115803 -
        Flags: superreview+

        Attachment #115803 -
        Flags: review+

    
    

    
  
checked in. Thanks!
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
QA Contact: jrgm → sairuh

    
    

    
  
vrfy'd fixed with 2003.03.13.05 comm trunk on rh8.0.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.