607084 - Editor tools rely on first name / last name, but AMO no longer supports those

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[Jorge Villalobos [:jorgev] (he/him)]

We use the first name / last name combination in several pages of the editor tools. A new editor just brought this to my attention because he never set those up, and there's no way to edit them in the new user edit pages.

It looks like at least the new editor list in https://addons.mozilla.org/en-US/editors and the review emails sent to authors lack the fallback to the username (or display name?).

Since first name and last name are no longer supported, we should use a new protocol here, maybe "Show display name, otherwise show username".

I'll try to get this fixed soon, before the migration to zamboni, since it can be confusing to developers.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: Patch V1. Switch to nickname on email subject, new editors and stats.

This patch changes first name + last name into nickname for email subjects, the new editors list and the stats summary in the editors summary page.

Comment 2

[Wil Clouser [:clouserw]]

Comment on attachment 487086 [details] [diff] [review]
Patch V1. Switch to nickname on email subject, new editors and stats.

Nickname is deprecated too.  The two that are in use are:  username and display_name.  I think display_name would be what you want for emails

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: Patch V2. Using display_name instead of nickname

Fixed to use display_name instead. Thanks.

Comment 4

[Wil Clouser [:clouserw]]

Comment on attachment 487452 [details] [diff] [review]
Patch V2. Using display_name instead of nickname

Thanks, that looks better

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Fixed, r76682.

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...