607133 - Remove the unneeded bits of toolkit/components/places/tests/unit/test_404630.js which hit the network, and thus make it flaky

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Phil Ringnalda (:philor)]

test_404630.js just failed multiple times across multiple trees, maybe from mozilla.org flakiness, or DNS flakiness in the build farm, or someone breaking mozilla.org/favicon.ico, or google.com was down, or who knows what.

In any case, it doesn't matter why: the test needs to be disabled until it is rewritten to not hit the network.

Comment 1

[Jesse Ruderman]

Timed out:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1290129976.1290132313.2312.gz&fulltext=1#err0

Comment 2

[Phil Ringnalda (:philor)]

Forgot to mention that I looked sometime later after the first instance, and the only part that actually has to successfully hit the network is google.com/favicon.ico, because the mozilla.com ones are supposed to just throw before they actually do anything.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

the last part of the test is useless, we have better tests for it.
I'll blindly review any patch removing the last call to setAndLoadFaviconForPage

Comment 4

[Phil Ringnalda (:philor)]

Attachment: Fix

Not too blind, please - I've never really paid much attention to how xpcshell tests work, though it did make it through one round on the tryserver.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 494307 [details] [diff] [review]
Fix

it looks fine!

Comment 6

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/1f2beffd84ff