60714 - need to define class name for Mozilla IM status window

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Masaki Katakai]

The original bug was submitted as,

http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=263

The IM status window grabs input focus at invoking
in some window manager. To avoid this problem, we
need to configure window manager not to pass
input focus to the Mozilla IM status window.
(same instruction of workaround attached in
http://bugzilla.mozilla.org/show_bug.cgi?id=47568)

Sawfish can configure this with "name" but
the "name" can not be used for WindowManaker,
which requires "class" name to configure.
So we need to define class name to status window.

Comment 1

[Masaki Katakai]

Attachment: patch to define class name

Comment 2

[Masaki Katakai]

Refer

http://www.tigr.net/afterstep/X/xlib/ICC/client-to-window-manager/wm-class.html

wm_class needs to be defined.

Comment 3

[R.K.Aa.]

is this related to bug 29856?

Comment 4

[Masaki Katakai]

it's different problem. We need to set class name properly
to IM window that isn't built with XUL.

Comment 5

[Shoji Matsumoto]

I made a patch against mozilla-0.7,
and validated on Vine Linux (VineSeed)
  kinput2-v3release-9
  WindowMaker-0.63.1-0vl3
  mozilla-0.7-3

with

  MozillaImStatus = {
    NoTitlebar = Yes;
    NoResizebar = Yes;
    NotClosable = Yes;
    NotMiniaturizable = Yes;
    KeepOnTop = Yes;
    Omnipresent = Yes;
    SkipWindowList = Yes;
    NoHideOthers = Yes;
    NoKeyBindings = Yes;
    NoMouseBindings = Yes;
    KeepInsideScreen = Yes;
    NoAppIcon = Yes;
    Unfocusable = Yes;
    DontSaveSession = Yes;
  };

into ~/GNUstep/Defaults/WMWindowAttributes.
-------------------------------------------------------
--- mozilla/widget/src/gtk/nsGtkIMEHelper.cpp.org       Sun Dec  3 01:06:29
2000+++ mozilla/widget/src/gtk/nsGtkIMEHelper.cpp   Thu Jan 11 05:11:09 2001
@@ -626,6 +626,13 @@

   XStoreName(display, mIMStatusWindow, "Mozilla IM Status");

+  // Some window managers (Window Maker and etc.) cannot handle windows
+  // with Name. Window Maker can handle with Class.
+  XClassHint class_hint;
+  class_hint.res_name = "mozilla-im-status";
+  class_hint.res_class = "MozillaImStatus";
+  XSetClassHint(display, mIMStatusWindow, &class_hint);
+
   long mask = ExposureMask;
   XSelectInput(display, mIMStatusWindow, mask);
 }

Comment 6

[Masaki Katakai]

Thank you Matsumoto-san, I'll check-in the patch after I get approval.

Comment 7

[Erik van der Poel]

sr=erik

Maybe blizzard would like to review as module owner and add his r=

Comment 8

[Christopher Blizzard (:blizzard)]

Yeah, looks fine.  sr=blizzard

Comment 9

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 10

[Masaki Katakai]

patch checked in

Comment 11

[ji]

Since I don't see the problem with linux 04/10 build on RH 6.2-J.
I'll mark it as verfied. Please feel free to reopen if you still have this
problem in your environment. Thanks.