The default bug view has changed. See this FAQ.

Aero broken when switch Basic/Aero Theme while minimize/un-minimize window

VERIFIED FIXED in mozilla10

Status

()

Core
Widget: Win32
VERIFIED FIXED
7 years ago
4 years ago

People

(Reporter: pal-moz, Assigned: bbondy)

Tracking

({regression})

Trunk
mozilla10
x86
Windows 7
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Reporter)

Description

7 years ago
Created attachment 486013 [details]
screenshot

[STR]
1) start Minefield, with (Windows 7) Basic Theme
2) minimize
3) switch to Aero Theme
4) un-minimize
5) Aero broken (see screenshot)

Updated

7 years ago
Component: Theme → General
Product: Firefox → Core
QA Contact: theme → general

Updated

7 years ago
Component: General → Widget: Win32
QA Contact: general → win32

Comment 1

7 years ago
A resize or even just a simple mouse over will trigger a full repaint. I see a similar effect with the menu bar enabled, although for some reason as soon as the window restores the paint triggers.
No longer blocks: 593950

Comment 2

7 years ago
This appears to be fixed in the latest nightly. Pal-moz, can you confirm?
(Reporter)

Comment 3

7 years ago
(In reply to comment #2)
> This appears to be fixed in the latest nightly. Pal-moz, can you confirm?

seems to be partially fixed.
but still broken for a while, about 1/5 - 1/4 seconds

I think this will be completely fixed by backout of bug 593950 . (this happened after/around this bug checkin)

Comment 4

6 years ago
Created attachment 499819 [details]
Screenshot of the Firefox bar going black

Comment 5

6 years ago
(In reply to comment #4)
> Created attachment 499819 [details]
> Screenshot of the Firefox bar going black

Sorry I should've put this in the attachement comments, new to Bugzilla. I'm on Firefox 4 Beta 8 and having the same problem. Here's my User Agent string:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8) Gecko/20100101 Firefox/4.0b8

Comment 6

6 years ago
This is still happening on the latest nightly but far less.

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b11pre) Gecko/20110202 Firefox/4.0b11pre

Comment 7

6 years ago
Reproducible on:
Mozilla/5.0 (Windows NT 6.1; rv:5.0a2) Gecko/20110417 Firefox/5.0a2

On the above build, the menu bar is not black anymore but transparent. But I suppose it address the same issue. Attached some screenshots.
Also, I am considering duping bug 621857 after this one, since has not yet been confirmed and was logged later

Comment 8

6 years ago
Created attachment 526732 [details]
ScreenshotOnAurora5.0.a2

Updated

6 years ago
Duplicate of this bug: 621857

Comment 10

6 years ago
Created attachment 558940 [details]
Screenshot of bug that is still present in v6.0.2

Added this to show the bug is still hanging around in v6 of the browser.
(Assignee)

Updated

6 years ago
Assignee: nobody → netzen
(Assignee)

Comment 11

6 years ago
Created attachment 559019 [details] [diff] [review]
Patch for fixing minimized window and theme change

The main thing that fixes the problem is passing in erase background when invalidating.  It is done synchronously to fix the problem sooner than later as it's a very infrequent message. 

I do this in both WM_DWMCOMPOSITIONCHANGED and WM_THEMECHANGED.

I would have changed the other Invalidate overload as well to have matching parameters, but that overload is part of nsIWidget so I didn't change it.

I'm using ::RedrawWindow instead of ::Invalidate now but as far as I can tell from MSDN the default functionality stays the same.
Attachment #559019 - Flags: review?(jmathies)
(Assignee)

Comment 12

6 years ago
Review ping

Comment 13

6 years ago
(In reply to Brian R. Bondy [:bbondy] from comment #12)
> Review ping

Unfortunatly I do not know how to review your changes so I am hoping someone else tests it for you, thanks for looking at the issue.

Comment 14

6 years ago
Comment on attachment 559019 [details] [diff] [review]
Patch for fixing minimized window and theme change

sorry for the delay. I like the new options, might come in handy.
Attachment #559019 - Flags: review?(jmathies) → review+
(Assignee)

Comment 15

6 years ago
Thanks for the review :)

Rebased and pushed to try:
https://hg.mozilla.org/try/rev/078ea1948daf
(Assignee)

Comment 16

6 years ago
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=8145967df486
(Assignee)

Comment 17

6 years ago
Pushed to inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/ba387863cf06
https://hg.mozilla.org/mozilla-central/rev/ba387863cf06
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10

Comment 19

6 years ago
Verified as fixed on:
Mozilla/5.0 (Windows NT 6.1; rv:10.0a1) Gecko/20111009 Firefox/10.0a1

This issue doesn't reproduce anymore using the steps in the bug description.
Status: RESOLVED → VERIFIED

Comment 20

4 years ago
Having this bug on
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20121128 Thunderbird/19.0a2
(Reporter)

Comment 21

4 years ago
(In reply to Petja Touru from comment #20)
> Having this bug on
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20121128
> Thunderbird/19.0a2

file a new bug.
You need to log in before you can comment on or make changes to this bug.