607415 - Can not select custom license as option, always defaults back to first option (Mozilla license)

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Mathias]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6) Gecko/20100101 Firefox/4.0b6
Build Identifier: 

I updated our iMacros for Firefox addon today. Normally we have a custom license ("other") but today I noted that it selects the first option (Mozilla license) EVEN IF I select the last option (Other).

Result: https://addons.mozilla.org/en-US/firefox/addon/3863/ displays the wrong license type. 

Plus, the license is displayed in Russian on our addon page.

I set the priority to major, as a wrong license could result to confusion/problems for some users or addon authors.

Reproducible: Always

Steps to Reproduce:
1. Upload (update) an addon and try to select "other" as license type

Note: I could test only with our addon, but assume it is a general bug.



Expected Results:  
Display custom license

Comment 1

[Mathias]

Attachment: Screenshot of the wrong license display (plus, it is in Russian)

Comment 3

[testit]

The problem is not only, that you can't select "other" when you upload a new version, the licenses which are linked on the versions page are also wrong.

As an example you can check the version page of Flashblock or CoolPreviews: https://addons.mozilla.org/en-US/firefox/addon/433/versions/
https://addons.mozilla.org/en-US/firefox/addon/2207/versions/

If you check where the link "custom license" for the different versions points to, you will see that it points to a different license for every version. If you check the custom licenses which are linked, you will see, that they are all empty.

So, this seems to be a general error and could cause pretty serious problems for every add-on author which uses a custom license. Therefore it should be fixed in my opinion as soon as possible. I can see "target milestone" 5.12.2. What's the schedule for this milestone?

Comment 4

[krupa raj[:krupa]]

> What's the schedule for this milestone?

5.12.2 is scheduled to go live on 11/09.

Comment 5

[Jeff Balogh (:jbalogh)]

r76329

QA: I tested this on the edit-version page, but we also need to look at new-version and new-addon.

Comment 6

[krupa raj[:krupa]]

Filed Bug 607689 - License selection does not stick when creating a new version

Also see, Bug 522386 -  License not carrying over between versions?

I was able to change the license from the edit version page. My license selection  was saved and did not revert to Mozilla license. https://preview.addons.mozilla.org/en-US/firefox/addon/228514/license/20101014

Calling this verified.

Comment 7

[Jeff Balogh (:jbalogh)]

This is fixed in prod now.