Closed Bug 607416 Opened 14 years ago Closed 14 years ago

Permanent Windows failure in toolkit/mozapps/extensions/test/browser/browser_uninstalling.js | Tried to remove an add-on that wasn't registered with the mock provider

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Platform:
x86
Windows Server 2008
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla2.0b7

People

(Reporter: ehsan.akhgari, Assigned: mossop)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

bustage fix
5.02 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review 
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1288118432.1288120867.11523.gz&fulltext=1
WINNT 5.2 mozilla-central debug test mochitest-other on 2010/10/26 11:40:32
I think the summary you actually wanted was "permaorange on Windows..." rather than "intermittent...".
Summary: Intermittent failure in toolkit/mozapps/extensions/test/browser/browser_uninstalling.js | Tried to remove an add-on that wasn't registered with the mock provider → Permanent Windows failure in toolkit/mozapps/extensions/test/browser/browser_uninstalling.js | Tried to remove an add-on that wasn't registered with the mock provider
We should back out Mossop's changes once the tree reopens.
Attached patch bustage fix — — Splinter Review 
The problem seems to be that one test tries to close the manager window while a child modal window is still open. This shifts the close attempt to after the child window has closed and the window has gotten focus again.

The extra window was basically hanging around for the remainder of the test run and then at the end when it was closed it would attempt to do some cleanup operations from earlier tests so throwing errors into the log.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #486162 - Flags: review?(robert.bugzilla)
Comment on attachment 486162 [details] [diff] [review]
bustage fix

Looks good
Attachment #486162 - Flags: review?(robert.bugzilla) → review+
Fix landed: http://hg.mozilla.org/mozilla-central/rev/1c42dfb39b1b
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
No more failures since the patch has been landed. Marking as verified fixed.
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: