607438 - use a blue highlight for url bar text

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

Right now we use a black highlight that we don't use anywhere else in the product:

http://www.flickr.com/photos/madhava_work/5118224081/

we should use our standard blue highlight instead.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Not sure why our selection was black, the patch turns back the selection to blue

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Can we set this in the color prefs in mobile.js instead of using CSS?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #2)
> Can we set this in the color prefs in mobile.js instead of using CSS?

Settings this as pref is not easy for us because of http://mxr.mozilla.org/mozilla-central/source/widget/src/android/nsLookAndFeel.cpp#55

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

OK. Maybe we should fix that. I'm thinking setting via prefs would be faster than setting via CSS. Thoughts?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

If we decide to fix Android look and feel, we can file a new bug. This can land post b2.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #4)
> OK. Maybe we should fix that. I'm thinking setting via prefs would be faster
> than setting via CSS. Thoughts?

Honestly , I don't know.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/f70e96772f1b

Comment 8

[Ayan Shah[:ashah]]

Verified Fixed on:

Mozilla/5.0(Macintosh; Intel Mac OS X 10.6;rv2.0b8pre) Gecko/20101102
Firefox/4.0b8pre Fennec/4.0b3pre