607456 - MozMill result summary should be printed after the application has shutdown

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

The MozMill result summary is currently printed after the tests have completed, but before the application has shut down.

On a non-debug build that is fine, as there's no logging on shutdown. However, with a debug build there's a whole load of debug spew on shutdown, and so the results get lost in the console backlog.

Attached is a patch that fixes it for me.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sounds like a good candidate for Mozmill 1.5.2. Lets ask Jeff for review. Thanks Mark.

Comment 2

[Jeff Hammel]

Comment on attachment 486173 [details] [diff] [review]
The fix

This is fine.  I don't see any problem, nor any particular advantage, but if it helps someone else out, might as well take it

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We don't accept any new patches for 1.5.1 right now. Lets Clint decide first, if it could be part of 1.5.1.

Comment 4

[cmtalbert]

Thanks for the patch, Mark! It looks simple and unobtrusive enough to pick up for 1.5.1.
 
Landed on 1.5.1: c43e35b1177a9e3a4c5d311b4329cdf4e5d48e72

Reviewed it for master, and I think the new report handling structure on master makes this unnecessary.  On 2.0, the report handler registers for the "stop" event.  When the stop event fires (due to mozmill.stop) then the final report is generated.  Jeff, if that's not how the new report stuff works then that's how it should ;)  But I believe I'm right. (famous last words).

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks good with a debug build. Thanks for the fix.