Open Bug 607459 Opened 14 years ago Updated 3 years ago

Session restore and undo tab close are broken if bfcache is turned off

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Platform:
x86
Windows XP
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
blocking2.0 --- -

People

(Reporter: polidobj, Unassigned)

Details

(Keywords: regression)

If I turn off the bfcache: (browser.sessionhistory.max_entries and browser.sessionhistory.max_total_viewers set to zero) then session restore does not work. The tabs are there after restarting the browser but they not are not loaded. The tabs content area is empty. Also undoing a tab close also does not load the tab in this case. 07-01 ok http://hg.mozilla.org/mozilla-central/rev/82edf5bd1abe 07-02 broken http://hg.mozilla.org/mozilla-central/rev/c173731c9d90 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=82edf5bd1abe&tochange=c173731c9d90 Nothing stands out as a cause. But of course bug 568691 was a major change.
Asking for blocking since this is a regression from 3.6.
blocking2.0: --- → ?
There doesn't seem to be anything obvious in that range to blame. I know the session restore side hasn't really changed in regards to that - we'll read max_entries, but we don't do too much with it. Boris, do you know of any session history changes that we might be able to blame?
Nothing in the comment 0 range looks relevant. And the bug mentioned in comment 3 shouldn't have done anything except _maybe_ make 0 in user prefs actually work. What regression range do you get if you set 0 in all.js?
Where is all.js?
Looks like in shipping builds it's stuffed into greprefs.js which is then stuffed into omni.jar.
It happens on Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9a2pre) Gecko/20070101 Minefield/3.0a2pre and earlier (browser.sessionhistory.max_entries;0 in defaults\pref\firefox.js) And I gave up.
Tentatively blocking- on this, since it's not the default nor common case. If you have specific reasons for holding the release on this, please state them.
blocking2.0: ? → -
(In reply to comment #7) > It happens on Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9a2pre) > Gecko/20070101 Minefield/3.0a2pre and earlier > (browser.sessionhistory.max_entries;0 in defaults\pref\firefox.js) > And I gave up. So you're saying this hasn't worked since before Firefox 3.0?
That's what Alice0775 said, yes.
I'm unable get the problem to occur in 3.6. Alice0775 are there any other steps other than setting browser.sessionhistory.max_total_viewers to zero in the prefs file?
(In reply to comment #11) > I'm unable get the problem to occur in 3.6. Alice0775 are there any other > steps other than setting browser.sessionhistory.max_total_viewers to zero in > the prefs file? I set only browser.sessionhistory.max_entries to 0 in defaults\pref\firefox.js.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.