If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

(typo) the process in advanced queries should not be "a any"

VERIFIED FIXED in 1.7.6

Status

Socorro
General
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: rhelmer, Assigned: lars)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
STR:

1) load http://crash-stats.mozilla.com/query/query?product=Firefox&version=Firefox%3A4.0b8pre&platform=windows&range_value=1&range_unit=weeks&date=10%2F26%2F2010+15%3A40%3A57&query_search=signature&query_type=exact&query=&build_id=&process_type=any&hang_type=any&do_query=1
2) Read first line under "Query Results"

Expected results:

"Results within 1 weeks of 10/26/2010 15:40:57, and the product is one of Firefox, and the version is one of Firefox:4.0b8pre, and the platform is one of windows and the crashing process was any."

Actual results:

"Results within 1 weeks of 10/26/2010 15:40:57, and the product is one of Firefox, and the version is one of Firefox:4.0b8pre, and the platform is one of windows and the crashing process was a any."
I noticed this in https://bugzilla.mozilla.org/show_bug.cgi?id=570613#c0, but never filed a spinoff bug for it; thanks, Rob!
(Assignee)

Comment 2

7 years ago
Created attachment 490987 [details] [diff] [review]
changes the awkward phrase "a any" to "of any type"

my python ide may have been over zealous in changing tabs to spaces and truncating trailing white space.  If this is a problem, I will gladly redo this using teco.
Attachment #490987 - Flags: review?(ryan)
Attachment #490987 - Flags: review?(robert)
(Reporter)

Comment 3

7 years ago
Comment on attachment 490987 [details] [diff] [review]
changes the awkward phrase "a any" to "of any type"

Patch looks fine, and WFM in testing:
any -> "Results within 1 weeks of 11/16/2010 14:37:58, and the product is one of Firefox and the crashing process was of any type."
browser -> "(...) and the crashing process was a browser."
plugin -> "(...) and the crashing process was a plugin.
Attachment #490987 - Flags: review?(robert) → review+
Comment on attachment 490987 [details] [diff] [review]
changes the awkward phrase "a any" to "of any type"

Looks good Lars.  Thanks for cleaning up visual issues in the code.  Unfortunately, there are many of those on the PHP side.
Attachment #490987 - Flags: review?(ryan) → review+
(Assignee)

Comment 5

7 years ago
this is done, but still resides on my development branch.  This will be merged into trunk on Wednesday, November 16 along with a bunch of other stuff.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.7.6
Verified FIXED on http://crash-stats.stage.mozilla.com/query/query?product=Firefox&version=Firefox%3A4.0b8pre&platform=windows&range_value=1&range_unit=weeks&date=10%2F26%2F2010+15%3A40%3A57&query_search=signature&query_type=exact&query=&build_id=&process_type=any&hang_type=any&do_query=1, now that this is merged back into trunk.
Status: RESOLVED → VERIFIED
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.