607503 - (typo) the process in advanced queries should not be "a any"

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Robert Helmer [:rhelmer]]

STR:

1) load http://crash-stats.mozilla.com/query/query?product=Firefox&version=Firefox%3A4.0b8pre&platform=windows&range_value=1&range_unit=weeks&date=10%2F26%2F2010+15%3A40%3A57&query_search=signature&query_type=exact&query=&build_id=&process_type=any&hang_type=any&do_query=1
2) Read first line under "Query Results"

Expected results:

"Results within 1 weeks of 10/26/2010 15:40:57, and the product is one of Firefox, and the version is one of Firefox:4.0b8pre, and the platform is one of windows and the crashing process was any."

Actual results:

"Results within 1 weeks of 10/26/2010 15:40:57, and the product is one of Firefox, and the version is one of Firefox:4.0b8pre, and the platform is one of windows and the crashing process was a any."

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

I noticed this in https://bugzilla.mozilla.org/show_bug.cgi?id=570613#c0, but never filed a spinoff bug for it; thanks, Rob!

Comment 2

[K Lars Lohn [:lars] [:klohn]]

Attachment: changes the awkward phrase "a any" to "of any type"

my python ide may have been over zealous in changing tabs to spaces and truncating trailing white space.  If this is a problem, I will gladly redo this using teco.

Comment 3

[Robert Helmer [:rhelmer]]

Comment on attachment 490987 [details] [diff] [review]
changes the awkward phrase "a any" to "of any type"

Patch looks fine, and WFM in testing:
any -> "Results within 1 weeks of 11/16/2010 14:37:58, and the product is one of Firefox and the crashing process was of any type."
browser -> "(...) and the crashing process was a browser."
plugin -> "(...) and the crashing process was a plugin.

Comment 4

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Comment on attachment 490987 [details] [diff] [review]
changes the awkward phrase "a any" to "of any type"

Looks good Lars.  Thanks for cleaning up visual issues in the code.  Unfortunately, there are many of those on the PHP side.

Comment 5

[K Lars Lohn [:lars] [:klohn]]

this is done, but still resides on my development branch.  This will be merged into trunk on Wednesday, November 16 along with a bunch of other stuff.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://crash-stats.stage.mozilla.com/query/query?product=Firefox&version=Firefox%3A4.0b8pre&platform=windows&range_value=1&range_unit=weeks&date=10%2F26%2F2010+15%3A40%3A57&query_search=signature&query_type=exact&query=&build_id=&process_type=any&hang_type=any&do_query=1, now that this is merged back into trunk.