607559 - Click on the star button doesn't popup "Edit Bookmark" for the first time

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[ithinc]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101026 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101026 Firefox/4.0b8pre

When chrome://browser/content/places/editBookmarkOverlay.xul is overlayed by an extension, click on the star button doesn't popup "Edit Bookmark" for the first time. A 2nd click will work. Error Console reports the following:

Error: this._element("editBookmarkPanelGrid") is null
Source file: chrome://browser/content/browser.js
Line: 2635


Reproducible: Always

Steps to Reproduce:
1. Overlay chrome://browser/content/places/editBookmarkOverlay.xul with:
<overlay id="editBookmarkOverlay"
         xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
  <vbox id="editBookmarkPanelContent">
    <checkbox id="editBMPanel_loadInTabCheckbox" collapsed="true"
              label="Load this bookmark in new tab"
              accesskey="A"
              insertafter="editBMPanel_loadInSidebarCheckbox"
              oncommand="alert('Hello');"
              observes="paneElementsBroadcaster">
      <observes element="additionalInfoBroadcaster" attribute="hidden"/>
    </checkbox>
  </vbox>
</overlay>

2. Restart firefox
3. Click the star button to add current url to bookmarks
4. Click the star button to edit current bookmark

Comment 1

[Andreea Pod]

This is meant to be. Clicking first time on the start saves your page as a bookmark at Unsorted Bookmarks.

Comment 2

[Shawn Wilsher :sdwilsh]

Unless the reporter means an already bookmarked page.

Comment 3

[Marco Bonardo [:mak]]

Still reproduceable in final version?
Could you please clarify about comment 1 and comment 2?
Also, do you have any add-ons interacting with this panel?

Comment 4

[ithinc]

I'm not sure whether it is still reproduciable in Firefox 4.0 final. In fact, Firefox crashes.

Step 1 means to make a tiny add-on, which will interact with the panel.
Step 3 makes the page bookmarked. 
Step 4 should open "Edit Bookmark" panel.

Comment 5

[Marco Bonardo [:mak]]

the editBookmarkPanelContent element is dynamically overlayed when the panel opens the first time (for txul reasons), so i suppose your overlay is somehow conflicting with our call to loadOverlay. Maybe you could try to overlay editBookmarkOverlay.xul

Comment 6

[Mark Banner (:standard8)]

Legacy add-ons are no longer supported.