607766 - securable-module tests fail on apparent string to regexp comparisons

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

On the latest Firefox trunk nightly, the securable-module tests fail on what appear to be comparisons between strings and regexps, specifically |error: fail: "access denied to import module: beets" != /access denied to import module: beets/|.

--------------------------------------------------------------------------------
(addon-sdk)myk@myk:~/Projects/addon-sdk/packages/jetpack-core$ cfx test -F securable-module
Using binary at '/home/myk/bin/firefox'.
Using profile at '/tmp/tmpJDPTE8.mozrunner'.

(firefox-bin:22963): GLib-WARNING **: g_set_prgname() called multiple times
.........................................error: TEST FAILED: test-securable-module.testSecurityPolicy (failure)
error: fail: "access denied to execute module: beets" != /access denied to execute module: beets/
info: Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/timer.js", line 64, in notifyOnTimeout
    this._callback.apply(null, this._params);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 255, in anonymous
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 280, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 298, in start
    this.test.testFunction(this);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 63, in runTest
    test(runner);
  File "resource://jetpack-core-jetpack-core-tests/test-securable-module.js", line 377, in anonymous
    /access denied to execute module: beets/);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 188, in assertRaises
    this.assertEqual(errorMessage, predicate, message);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 227, in assertEqual
    this.fail(message);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 145, in fail
    console.trace();
error: fail: "access denied to import module: foo" != /access denied to import module: foo/
info: Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/timer.js", line 64, in notifyOnTimeout
    this._callback.apply(null, this._params);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 255, in anonymous
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 280, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 298, in start
    this.test.testFunction(this);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 63, in runTest
    test(runner);
  File "resource://jetpack-core-jetpack-core-tests/test-securable-module.js", line 379, in anonymous
    /access denied to import module: foo/);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 188, in assertRaises
    this.assertEqual(errorMessage, predicate, message);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 227, in assertEqual
    this.fail(message);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 145, in fail
    console.trace();
.error: fail: "access denied to import module: beets" != /access denied to import module: beets/
info: Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/timer.js", line 64, in notifyOnTimeout
    this._callback.apply(null, this._params);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 255, in anonymous
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 280, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 298, in start
    this.test.testFunction(this);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 63, in runTest
    test(runner);
  File "resource://jetpack-core-jetpack-core-tests/test-securable-module.js", line 386, in anonymous
    /access denied to import module: beets/);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 188, in assertRaises
    this.assertEqual(errorMessage, predicate, message);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 227, in assertEqual
    this.fail(message);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 145, in fail
    console.trace();
...
45 of 48 tests passed.
FAIL
Total time: 1.761104 seconds
Program terminated unsuccessfully.
--------------------------------------------------------------------------------

Atul: might you have an idea what's going on here?

Comment 1

[Drew Willcoxon :adw]

This has the same root problem as bug 607768.

Comment 2

[Drew Willcoxon :adw]

Fixed by bug 607768 for 0.10.  I'll leave the dependency on bug 607799 so it's clear what broke.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".