607841 - Only 2 tabs fit per column in portrait mode with VKB opened

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

When the VKB is opened and the screen is in portrait mode, only 2 tabs fits on the tabs sidebar.

For this type of cases where the screen is very small Matt suggested to use a media query which I think is a good idea.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Do we really need to see tabs with the VKB open? I don't mind shrinking padding, as long as it looks good. I'd rather just set good padding once, and not worry about changing it.

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 486526 [details] [diff] [review]
Patch

Looks fine to me; we should run this by Madhava too.

Comment 3

[Madhava Enros [:madhava]]

Is there a screenshot?

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Screenshot from device

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #1)
> Do we really need to see tabs with the VKB open? 

Not really, to be honest this is probably an edge case

> I don't mind shrinking padding, as long as it looks good. I'd rather just set
> good padding once, and not worry about changing it.

I tend to agree with you here, so if the padding is fine to Madhava for having it permanently I'm for it. Otherwise, since this is an edge case I don't have any problems for having an exception for it.

Comment 6

[Madhava Enros [:madhava]]

I guess this came about from our saying that panning shouldn't dismiss the vkb - nothing is simple, I guess.

It looks fine to me.  In my perfect world, we wouldn't have to rearrange tabs, but given that the alternative is for some to be hidden, I'll take this.

The keyboard disappears when you switch tabs, though, right? i.e., keyboards shown/hidden is a property of the current tab?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

I started to think the displaying the tabs in multiple columns is part of the problem. I think we should consider making the list of tabs be pannable and only ever be a single column.

Multiple columns is taking up too much space, and VKB is only exasperating the situation.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #7)
> I started to think the displaying the tabs in multiple columns is part of the
> problem. I think we should consider making the list of tabs be pannable and
> only ever be a single column.
> 
> Multiple columns is taking up too much space, and VKB is only exasperating the
> situation.

I do like having multiple columns, maybe we could limit the number of visible columns and let the UI be pannable horizontally if needed.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

See bug 611878

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

See bug 609733

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

see bug 609600

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This bug will be resolved by bug 614496

Comment 13

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b9pre) Gecko/20101227 Namoroka/4.0b9pre Fennec/4.0b4pre

Comment 14

[Ioana Chiorean]

https://litmus.mozilla.org/show_test.cgi?id=15197