607882 - shutdown document accessible may stay in cache

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

there are cases when outerdoc accessible gets shutdown and then it shutdowns the underlying document accessible so that the document accessible isn't removed from cache. This may lead to crashes if we get notifications for shutdown documents from layout (I saw some from ReResolveStyleContext - patch from bug 606125). It's regression from 570275, prior this bug we didn't shutdown the document accessible from outerdoc accessible shutdown because we traversed DOM tree.

I suggest to allow the document to shutdown itself completely and make him to shutdown its subdocuments.

Comment 1

[alexander :surkov (:asurkov)]

http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-ff8495ff333a

Comment 2

[Ginn Chen]

Comment on attachment 486559 [details] [diff] [review]
patch

Looks correct to me.


+  for (PRUint32 idx = 0; idx < childDocCount; idx++)
+    mChildDocuments.ElementAt(idx)->Shutdown();

mChildDocuments[idx]->Shutdown();
would be easier for reading.

Comment 3

[alexander :surkov (:asurkov)]

landed with Ginn's comment addressed - http://hg.mozilla.org/mozilla-central/rev/fe4898e97431