607900 - [startup-notification] Two windows started when Firefox launched for the first times

Status: RESOLVED FIXED

(Firefox :: General, defect, P4)

Description

[vicky.sun]

Attachment: Screenshot

Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.9.2.12) Gecko/20101027 Firefox/3.6.12

Steps to reproduce:
1. Remove .mozilla
2. Launch FF3.6.12 from menu (not terminal)

Actual Result:
Two windows appear in panel: "Welcome to Firefox..." and "Starting Firefox Web Browser"
For screenshot,please refer to attachment 

Expected Result:
Only "Welcome to Firefox..." should be started

Comment 1

[Ginn Chen]

StartupNotify problem.

Comment 2

[Ginn Chen]

If $/.mozilla is not there, we do LaunchChild() in ImportProfiles().
But we didn't set DESKTOP_STARTUP_ID in this path.

We might want to always set DESKTOP_STARUP_ID again, and unset it when Firefox is really started.

Comment 3

[Ginn Chen]

Attachment: patch

See also Bug 416053, Bug 534845

Comment 4

[Ginn Chen]

Comment on attachment 493652 [details] [diff] [review]
patch

low risk, actually startupid is not used without --enable-startup-notification

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 493652 [details] [diff] [review]
patch

But is that flag used by any Linux distros?

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 493652 [details] [diff] [review]
patch

Clearing flag; Ginn, renominate if you have an answer for the previous comment.

Comment 7

[Ginn Chen]

Comment on attachment 493652 [details] [diff] [review]
patch

Firefox in Ubuntu 10.10 uses --enable-startup-notification.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 493652 [details] [diff] [review]
patch

I'd like to get glandium's sign off on this, then.

Comment 9

[Mike Hommey [:glandium]]

Comment on attachment 493652 [details] [diff] [review]
patch

I can reproduce the issue on Debian (we do use --enable-startup-notification on our builds), and I can confirm the patch fixes it.

Note that there is another related issue that the patch doesn't fix (and that I hadn't noticed before): when you have several profiles in $HOME/.mozilla/firefox, and uncheck the "Don't ask at startup" box, the "waiting icon" is displayed while being in the profile manager.

Comment 10

[Ginn Chen]

That is a different problem.
We don't set startup id for the profile manager dialog.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 493652 [details] [diff] [review]
patch

a=beltzner

Comment 12

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/f011b244508d