607922 - Once the awesome panel is opened, the Search button should open the open search menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Since we won't re-open the VKB until the user clicks on the urlbar field (bug 605583) and because the "Search" button icon on Android is the same as the Open search menu of the Awesome panel, I think it makes sense to have it open the Awesome panel and it could open the "Open search menu" if the awesome panel is already opened

The patch also fixed a small bug where the open search menu keeps an opened state after clicking on a search engine (we can see it with the background-color)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 486587 [details] [diff] [review]
Patch

Makes sense to me. Let's make sure Madhava OK's this behavior too.

Comment 2

[Madhava Enros [:madhava]]

Yeah, let's try it.  The whole screen is about search, so there's nothing else (other than re-focusing the search field?) it would do.  But really, the field should never be really unfocused anyway while you're on this screen.

Let's try this out and see what the feedback is.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/c43b6f365ee5

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/c43b6f365ee5

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Search button will open the awesome page, if it's pressed again then it opens the search panel, if it's pressed again then it closes the search panel.

Mozilla/5.0 (Android; Linux armv71; rv2.0b8pre) Gecko/20101104 Firefox/4.0b8pre Fennec/4.0b3pre

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #5)
> Search button will open the awesome page, if it's pressed again then it opens
> the search panel, if it's pressed again then it closes the search panel.
> 

yes, this is what's expected

Comment 7

[Ayan Shah[:ashah]]

https://litmus.mozilla.org/show_test.cgi?id=13772