607956 - [Regression] Panning can be locked on the X axis while the UI is only scrollable on Y

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Steps to reproduce:
 * go to the preference panel
 * pan from left to right on a big part of the window width
 * try to pan to top or bottom
 
Actual result:
 * nothing happen

Expected result:
 * The UI scroll to the top or the bottom since there is no reason for locking the scroll horizontally

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 486607 [details] [diff] [review]
Patch

A comment here would be good. So we don't change this code without knowing why it's here.

Also, is there no good way to move this check into DragData? lockedX and lockedY are not really used outside of DragData, so I was just wondering if leaking them outside is not a good thing.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Address comments

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 486806 [details] [diff] [review]
Patch v0.2

I think I like this better.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/a841c83ae5a5

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

note : bug 609619
Not sure if it's related.

Verified:
Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b8pre) Gecko/20101104 Firefox/4.0b8pre Fennec/4.0b3pre
Mozilla/5.0 (Android; Linux armv71; rv2.0b8pre) Gecko/20101104 Firefox/4.0b8pre Fennec/4.0b3pre