Random failures in the build system trying to remove the repo directory

VERIFIED FIXED

Status

Tamarin
Build Config
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Brent Baker, Assigned: Brent Baker)

Tracking

unspecified
Bug Flags:
flashplayer-qrb +
flashplayer-triage +

Details

(Whiteboard: buildbot)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 486660 [details] [diff] [review]
usePTY="False" when calling sync_Clean

There have been a couple of random failures in the build system happening when trying to remove the "repo" directory. Logging into the machine after the failure shows that the directory was in fact deleted and appears that there should not have been any issue.

logfile:
2010-10-28 12:25:01-0400 [Broker,client]  startCommand:shell [id 18509]
2010-10-28 12:25:01-0400 [Broker,client] ShellCommand._startCommand
2010-10-28 12:25:01-0400 [Broker,client]  rm -Rf repo
2010-10-28 12:25:01-0400 [Broker,client]   in dir /home/build/buildbot/tamarin-redux/linux/./sandbox-linux2-test/../ (timeout 1200 secs)
2010-10-28 12:25:01-0400 [Broker,client]   watching logfiles {}
2010-10-28 12:25:01-0400 [Broker,client]   argv: ['rm', '-Rf', 'repo']
2010-10-28 12:25:01-0400 [Broker,client]   closing stdin
2010-10-28 12:25:01-0400 [Broker,client]   using PTY: True
2010-10-28 12:25:02-0400 [-] command finished with signal 1, exit code None, elapsedTime: 1.448545


Doing a little searching it appears that this has been a known issue that can happen in buildbot and was tracked via 2 separate bugs [1][2]

Since the version of buildbot that we are currently using does not have this patch, and the fact that we use our own "clean" step, we just need to create the build step with usePTY="False".

[1] http://buildbot.net/trac/ticket/255
[2] http://buildbot.net/trac/ticket/284
Flags: flashplayer-triage+
Flags: flashplayer-qrb+
Attachment #486660 - Flags: review?(cpeyer)
(Assignee)

Comment 1

7 years ago
Created attachment 486665 [details] [diff] [review]
v2. usePTY="False" when calling sync_Clean

add the same check to the bb_slaveupdate build step that just does a quick 'cp' call, which is also mentioned as a possible problem in the comments of the buildbot trac issue (found while reading entire thread)
Assignee: nobody → brbaker
Attachment #486660 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #486665 - Flags: review?(cpeyer)
Attachment #486660 - Flags: review?(cpeyer)
(Assignee)

Updated

7 years ago
Attachment #486665 - Attachment is patch: true

Updated

7 years ago
Attachment #486665 - Flags: review?(cpeyer) → review+
(Assignee)

Comment 2

7 years ago
Comment on attachment 486665 [details] [diff] [review]
v2. usePTY="False" when calling sync_Clean

Patch pushed and deployed as 5462:5a7d5f01296a
(Assignee)

Comment 3

7 years ago
final patch pushed as 5475:33edebac2097
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

7 years ago
Marking as verified, the build system has been running for 5 days without the same issue.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.