608061 - no help-topic redirect is wrong

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Vishal Kamdar [:vish_moz]]

no help-topic redirect is wrong:

http://master.support.mozilla.com/1/firefox/4.0b2/Linux/en-US/
  redirects to 
http://master.support.mozilla.com/en-US/http:/master.support.mozilla.com/en-US/kb/Get help with Firefox 4 beta/firefox/4.0b2/Linux/en-US?style_mode=inproduct&as=u

Expected:http://master.support.mozilla.com/en-US/kb/Get help with Firefox 4 beta/firefox/4.0b2/Linux/en-US?style_mode=inproduct&as=u

Actual: double http://master.support.mozilla.com/en-US

Comment 1

[James Socol [:jsocol, :james]]

Michael, I've fixed the issue with the redirect, but the article "Get help with Firefox 4 beta" isn't there. Is this something missing from the migration, or should this go to a new target?

Comment 2

[James Socol [:jsocol, :james]]

Attachment: updated htaccess

Fixes all the "home page" redirects, especially the beta redirect. Also fixes the issue in bug 610354, and fixes password reset, as well.

Comment 3

[Verdi [:verdi] Best to slack me]

Cheng is "Get help with Firefox 4 beta" the special fx 4 landing page? What did we decide to do with that?

Comment 4

[[:Cww]]

For the beta, I think we're going to have to keep with a special page since the timing is so off from our original plan.  We probably should re-write it to be nicer, though.

Comment 5

[James Socol [:jsocol, :james]]

Please make sure Paul knows to include that document in the migration on bug 586487.

Vishal: Note that the beta redirect in comment 0 will still be a 404 until we migrate that document. I've fixed the double-domain issue, though.

Comment 6

[Paul Craciunoiu [:paulc]]

Comment on attachment 489172 [details] [diff] [review]
updated htaccess

>Index: webroot/htaccess.dist
>===================================================================
>--- webroot/htaccess.dist	(revision 76741)
>+++ webroot/htaccess.dist	(working copy)
>@@ -49,10 +52,10 @@
> RewriteRule ^1/([\-a-zA-Z]+)/([0-9]+\.[0-9]+[^/]*)/([\-_a-zA-Z0-9]+)/sr/([\-_a-zA-Z]+)$   /1/$1/$2/$3/sr-CYRL/$4/ [L,R]
> 
> # Redirect no help topic to main in-product page
>-RewriteRule ^1/Firefox/4\.0b\d[^/]*/([\-_a-zA-Z0-9]+)/([\-a-zA-Z]+)\/$ "/$2/kb/Get help with Firefox 4 beta?style_mode=inproduct&as=u" [R,NC]
>+RewriteRule ^1/Firefox/4\.0b\d[^/]*/([\-_a-zA-Z0-9]+)/([\-a-zA-Z]+)\/$ "/$2/kb/Get help with Firefox 4 beta?style_mode=inproduct&as=u" [L,R,NC]
> RewriteRule ^1/([\-a-zA-Z]+)/([0-9]+\.[0-9]+[^/]*)/([\-_a-zA-Z0-9]+)/([\-a-zA-Z]+)$   /1/$1/$2/$3/$4/ [L,R]
> RewriteRule ^1/([\-a-zA-Z]+)/([0-9]+\.[0-9]+[^/]*)/iPhone/([\-a-zA-Z]+)/?$  "/$3/kb/What is Firefox Home" [L,R,NE]
>-RewriteRule ^1/([\-a-zA-Z]+)/([0-9]+\.[0-9]+[^/]*)/([\-_a-zA-Z0-9]+)/([\-a-zA-Z]+)\/$  "/$4/kb/Firefox Help?style_mode=inproduct" [L,R,NE]
>+RewriteRule ^1/([\-a-zA-Z]+)/([0-9]+\.[0-9]+[^/]*)/([\-_a-zA-Z0-9]+)/([\-a-zA-Z]+)\/$  "/$4/home/" [L,R,NE]
Seems like for all the other rewrites you kept the style_mode parameter except for this one.


The rest looks good I think.

Comment 7

[James Socol [:jsocol, :james]]

Attachment: another patch

Comment 8

[Paul Craciunoiu [:paulc]]

Comment on attachment 489240 [details] [diff] [review]
another patch

WFM.

Comment 9

[James Socol [:jsocol, :james]]

r77163.

May take a while to show up.

Comment 10

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.