608100 - _validate_is_localizable needs a case for parentless non-English docs

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P2)

Description

[Erik Rose [:erik][:erikrose]]

...and it should assert that is_localizable==False.

Comment 1

[James Socol [:jsocol, :james]]

Doesn't Document.save enforce that if locale != default, set is_localizable=False, anyway?

Comment 2

[Erik Rose [:erik][:erikrose]]

No, but that's a good idea.

Comment 3

[Erik Rose [:erik][:erikrose]]

clean() did, but save() didn't. Does now.

Comment 4

[James Socol [:jsocol, :james]]

Is there something I can do through the UI to test this patch?

Comment 5

[Erik Rose [:erik][:erikrose]]

Not that I know of; this is mostly a check against potential bad migrations (or any other non-form code that calls save() without calling clean() first). Paul and I noticed the need together, but I don't recall the specific situation anymore. The idea, of course, is that any call to Document.save() on a non-English doc with is_localizable=True should cause is_localizable to be set to False--which is just what the unit test does.

Comment 6

[Erik Rose [:erik][:erikrose]]

Landed in https://github.com/jsocol/kitsune/commit/4947eb01d73b2148c7b9be194ea75f02cb2ba0f5.

Comment 7

[Rebecca Billings [:rbillings]]

Closed as [qa-]