Adapt to symbols upload changes for post-upload command in bug 607951 and friends

RESOLVED FIXED

Status

Camino Graveyard
General
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: Smokey Ardisson (offline for a while; not following bugs - do not email))

Tracking

Details

(Whiteboard: [camino-2.0.6])

Attachments

(3 attachments, 2 obsolete attachments)

Comment hidden (empty)
Per bug 607951, it looks like we'll need to make only 2 changes (on all active branches):

1) 'export'ing the symbols index filename in our Makefile (so it's available to the environment and scripts)

2) setting the 'POST_SYMBOL_UPLOAD_CMD' env variable in all of our tinderconfigs.  We'll need to know the final path to the command that we should use.

In addition,

3) We'll need to ensure that the relevant changes to toolkit's upload-symbols.sh land on 1.9.0 for Camino 2.0.x builds ;)

4) We'll probably want to port changes to the final upload command into the re-upload script generation: http://mxr.mozilla.org/camino/source/camino/Makefile.in#436
Depends on: 607951
Created attachment 487518 [details] [diff] [review]
Makefile changes

This should do 1 and 4, the Makefile bits.
Attachment #487518 - Flags: superreview?(stuart.morgan+bugzilla)
And for the tinderconfigs, the path-value for the new env variable appears to be '/usr/local/bin/post-symbol-upload.py'

I'll upload the tinderconfig diffs (for sanity) later.
Created attachment 488115 [details] [diff] [review]
1.9.2 tinder-configs

Stuart, just looking for a sanity-check from you on these two patches; we really only care about cb-x1 (the one with no machine-name in the path) and cb-x4, but I've modified the other configs that had symbols info to keep them updated.
Attachment #488115 - Flags: superreview?(stuart.morgan+bugzilla)
Created attachment 488116 [details] [diff] [review]
CAMINO_2_0_BRANCH tinder-configs
Attachment #488116 - Flags: superreview?(stuart.morgan+bugzilla)
Comment on attachment 488116 [details] [diff] [review]
CAMINO_2_0_BRANCH tinder-configs

(I've also made this change to the on-machine Cm2.0.5 tinder-config, so that when it gets copied and edited for 2.0.6, it will pick up this change without me forgetting.)

Comment 7

8 years ago
Comment on attachment 487518 [details] [diff] [review]
Makefile changes

sr=smorgan
Attachment #487518 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+

Comment 8

8 years ago
Comment on attachment 488115 [details] [diff] [review]
1.9.2 tinder-configs

sr=smorgan
Attachment #488115 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+

Updated

8 years ago
Attachment #488116 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Holding off on landing the tinder-configs until there's movement on bug 607951 and/or bug 607946 and/or branch movement on bug 607946.

I don't want to get us into a situation where upload-symbols.sh has been updated on the branches to use the command but the command (or its no-op version) hasn't been installed on the symbols upload server and causes errors when doing symbol upload, which would be a situation where the otherwise no-op tinder-config changes became op.
Status: NEW → ASSIGNED
Whiteboard: [camino-2.0.6]
Created attachment 489754 [details] [diff] [review]
1.9.2 tinder-configs

Now with less build failures due to missing ;s
Attachment #488115 - Attachment is obsolete: true
Created attachment 489756 [details] [diff] [review]
CAMINO_2_0_BRANCH tinder-configs

Now with less build failures due to missing ;s
Attachment #488116 - Attachment is obsolete: true
Bug 607946 is in on branches, and bug 609270 is also live (the no-op version), so I landed the tinder-config changes on both branches.

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=&branchtype=match&dir=%2Fmozilla%2Fcamino+%2Fmozilla%2Ftools%2Ftinderbox-configs%2Fcamino&sortby=Date&hours=2&date=explicit&mindate=2010-11-19+00%3A00&maxdate=2010-11-20+00%3A00&cvsroot=%2Fcvsroot

That means we're all ready whenever bug 607951 and bug 607961 happen to land.  It doesn't look like it'll happen while I'm gone, but I'll've definitely forgotten about this by the time I'm back.

We'll need to check tomorrow's nightlies' symbol uploads to make sure they went OK, though.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(And I've updated my OS Symbols convenience scripts to fetch and export the symbol index filename and the post-upload command path, too: http://hg.mozilla.org/users/alqahira_ardisson.org/misc/rev/0648e3037b5b  As long as we keep cb-x1's 2.1 tinderconfig updated, I'll pull the right thing [and we can change it to cb-x4 if we need to, but x1 has a shorter path :P ])
You need to log in before you can comment on or make changes to this bug.