608272 - When solitary tab crashes and is closed the preview remains

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wil Clouser [:clouserw]]

This isn't a big deal, but I can reliably crash a tab (bug 608271) and if I choose to close the tab (and it's the only tab open) I see a completely white screen.  If I look at my list of tabs, the one that crashed is still there, but clicking on it does nothing.  Opening a new tab and then clicking on the old one reloads the old page, which is good functionally, but if the tab is closed, it's weird it's still there.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I bet this is because the tab is the only tab you had open. We have code that ignores closing a tab if it is the last tab so you don't end up with zero tabs. We need to modify that code.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch just makes sure we have at least one tab always open, even if we close after a crash.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/68fd768fecf5

Comment 4

[Anna (Waverley)]

I can not crash a tab... in order to see what happens if I close it. Can someone please verify this ?

Comment 5

[Josh Matthews [:jdm]]

Ted's extension allows you to crash processes at will: http://code.google.com/p/crashme/downloads/detail?name=crashme-new.xpi&can=2&q=