center awesomebar category headers (landscape)

NEW
Assigned to

Status

Fennec Graveyard
General
P1
trivial
7 years ago
7 years ago

People

(Reporter: madhava, Assigned: vingtetun)

Tracking

({polish})

Trunk
x86
Mac OS X
polish

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

7 years ago
As pictured here:
http://www.flickr.com/photos/madhava_work/5126312780/

we should center the "[icon] Title" headers in their header blocks.
(Reporter)

Updated

7 years ago
Keywords: polish
(Reporter)

Updated

7 years ago
tracking-fennec: --- → ?
tracking-fennec: ? → 2.0+
Assignee: nobody → 21
Severity: normal → trivial
Priority: -- → P1
Whiteboard: [e1]
Created attachment 510555 [details] [diff] [review]
m-c part

This patch add spacer to the list of "includes" children of the toolbarbutton binding. 
I need it to be able to horizontally centered the childs of the toolbarbutton (see front-end part of the same bug) unless I have missed a much easier way?
Attachment #510555 - Flags: review?
Attachment #510555 - Flags: review? → review?(gavin.sharp)
Created attachment 510556 [details] [diff] [review]
Patch (Front-End)
Attachment #510556 - Flags: review?(mark.finkle)
Comment on attachment 510555 [details] [diff] [review]
m-c part

When I originally suggested using a <spcaer flex="1"/>, I was thinking of a quick-hack we could do in the front-end with some CSS :before rules.

If we really want to move this to platform, I think we should remove the hardcoded "flex" from the <label> and add "-moz-box-flex:1" to the toolbarbutton-text class.

Let's see what gavin suggests
(In reply to comment #3)
> When I originally suggested using a <spcaer flex="1"/>, I was thinking of a
> quick-hack we could do in the front-end with some CSS :before rules.

I'm not sure we can't generate flexible element with :before, but I've not checked!

> If we really want to move this to platform, I think we should remove the
> hardcoded "flex" from the <label> and add "-moz-box-flex:1" to the
> toolbarbutton-text class.

That was my first idea too, but I think playing with -moz-box-flex is a bad idea here since setting it to 0 for the label will inhibit cropping :/
Created attachment 510748 [details] [diff] [review]
m-c patch

I agree with Mark - something like this should be less invasive and allows you to override the flex with CSS.
Attachment #510555 - Attachment is obsolete: true
Attachment #510748 - Flags: review?(enndeakin)
Attachment #510555 - Flags: review?(gavin.sharp)
Comment on attachment 510748 [details] [diff] [review]
m-c patch

Oh, I didn't see your comment about cropping. That seems odd... One of the Neil's would probably have better advice for what to do here than I would.
Attachment #510748 - Flags: review?(enndeakin)

Comment 7

7 years ago
What layout are you trying to acheive here?
Created attachment 511343 [details]
screenshot

(In reply to comment #7)
> What layout are you trying to acheive here?

What I'm trying to do here is to have a toolbarbutton with the content (image + button) centered horizontally.
I also want to keep the flex + crop attributes of the label.

But the flex box of the label (red box on the screenshot) push the content to the left, so I looking for a way to counterbalanced that. My suggestion is offering the possibility to add a <spacer flex="1"/> to the left (blue box on the screenshot) to achieve that.

I could have missed a better an easy way to do it.
Neil - Any thoughts on this?
we'll take a patch for this if it comes, but it won't block the release
tracking-fennec: 2.0+ → 2.0-
Whiteboard: [e1] → [fennec-4.1?]
Comment on attachment 510556 [details] [diff] [review]
Patch (Front-End)

I guess I need to fix that in the front-end side only.
Attachment #510556 - Flags: review?(mark.finkle)
tracking-fennec: - → 6+
Whiteboard: [fennec-4.1?]
Let's unbitrot this and get it reviewed
tracking-fennec: 6+ → -
You need to log in before you can comment on or make changes to this bug.