608282 - center awesomebar category headers (landscape)

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Madhava Enros [:madhava]]

As pictured here:
http://www.flickr.com/photos/madhava_work/5126312780/

we should center the "[icon] Title" headers in their header blocks.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: m-c part

This patch add spacer to the list of "includes" children of the toolbarbutton binding. 
I need it to be able to horizontally centered the childs of the toolbarbutton (see front-end part of the same bug) unless I have missed a much easier way?

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch (Front-End)

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 510555 [details] [diff] [review]
m-c part

When I originally suggested using a <spcaer flex="1"/>, I was thinking of a quick-hack we could do in the front-end with some CSS :before rules.

If we really want to move this to platform, I think we should remove the hardcoded "flex" from the <label> and add "-moz-box-flex:1" to the toolbarbutton-text class.

Let's see what gavin suggests

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #3)
> When I originally suggested using a <spcaer flex="1"/>, I was thinking of a
> quick-hack we could do in the front-end with some CSS :before rules.

I'm not sure we can't generate flexible element with :before, but I've not checked!

> If we really want to move this to platform, I think we should remove the
> hardcoded "flex" from the <label> and add "-moz-box-flex:1" to the
> toolbarbutton-text class.

That was my first idea too, but I think playing with -moz-box-flex is a bad idea here since setting it to 0 for the label will inhibit cropping :/

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: m-c patch

I agree with Mark - something like this should be less invasive and allows you to override the flex with CSS.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 510748 [details] [diff] [review]
m-c patch

Oh, I didn't see your comment about cropping. That seems odd... One of the Neil's would probably have better advice for what to do here than I would.

Comment 7

[Neil Deakin (away until Sept 6)]

What layout are you trying to acheive here?

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: screenshot

(In reply to comment #7)
> What layout are you trying to acheive here?

What I'm trying to do here is to have a toolbarbutton with the content (image + button) centered horizontally.
I also want to keep the flex + crop attributes of the label.

But the flex box of the label (red box on the screenshot) push the content to the left, so I looking for a way to counterbalanced that. My suggestion is offering the possibility to add a <spacer flex="1"/> to the left (blue box on the screenshot) to achieve that.

I could have missed a better an easy way to do it.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Neil - Any thoughts on this?

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

we'll take a patch for this if it comes, but it won't block the release

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 510556 [details] [diff] [review]
Patch (Front-End)

I guess I need to fix that in the front-end side only.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's unbitrot this and get it reviewed

Comment 13

[BMO Automation]

Closing all opened bug in a graveyard component