608296 - add prereqs for buildbotconfig to buildmaster patches

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P5)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

According to my notes, we need
  pycrypto
  pyasn1
  argparse

installed in order to run a buildmaster.  Since the only thing that we install in virtualenvs is hg.m.o/build/buildbot, it makes sense to add these as deps in its setup.py.

I have grander plans that involve packaging all of this stuff along with a fancy script to put up a master in one go -- but for now, this would be a nice improvement (IMHO..)

Comment 1

[Chris Cooper [:coop] (he/him)]

Dustin: is this something you wanted to take on, or just filing it to get it tracked?

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

I'll do it, as long as it doesn't sound crazy.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: 608296.patch

Also at
  http://hg.mozilla.org/users/dmitchell_mozilla.com/buildbot/rev/36e4e81d84db

Is an uploaded patch required for review, or is it OK to just point to an hg rev?

Comment 4

[Chris Cooper [:coop] (he/him)]

Comment on attachment 489421 [details] [diff] [review]
608296.patch

(In reply to comment #3)
> Is an uploaded patch required for review, or is it OK to just point to an hg
> rev?

Sadly it's the only way to do the review/approval flag dance which is central to the Mozilla process, and it's better than uploading an empty file to do the same.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 489421 [details] [diff] [review]
608296.patch

landed - b7b751d9df42