Closed Bug 608296 Opened 10 years ago Closed 10 years ago

add prereqs for buildbotconfig to buildmaster patches

Categories

(Release Engineering :: General, defect, P5)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dustin, Assigned: dustin)

Details

(Whiteboard: [automation][buildmasters])

Attachments

(1 file)

According to my notes, we need
  pycrypto
  pyasn1
  argparse

installed in order to run a buildmaster.  Since the only thing that we install in virtualenvs is hg.m.o/build/buildbot, it makes sense to add these as deps in its setup.py.

I have grander plans that involve packaging all of this stuff along with a fancy script to put up a master in one go -- but for now, this would be a nice improvement (IMHO..)
Dustin: is this something you wanted to take on, or just filing it to get it tracked?
Priority: -- → P5
Whiteboard: [automation][buildmasters]
I'll do it, as long as it doesn't sound crazy.
Assignee: nobody → dustin
Status: NEW → ASSIGNED
Attached patch 608296.patchSplinter Review
Also at
  http://hg.mozilla.org/users/dmitchell_mozilla.com/buildbot/rev/36e4e81d84db

Is an uploaded patch required for review, or is it OK to just point to an hg rev?
Attachment #489421 - Flags: review?(coop)
Comment on attachment 489421 [details] [diff] [review]
608296.patch

(In reply to comment #3)
> Is an uploaded patch required for review, or is it OK to just point to an hg
> rev?

Sadly it's the only way to do the review/approval flag dance which is central to the Mozilla process, and it's better than uploading an empty file to do the same.
Attachment #489421 - Flags: review?(coop) → review+
Comment on attachment 489421 [details] [diff] [review]
608296.patch

landed - b7b751d9df42
Attachment #489421 - Flags: checked-in+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.