608331 - Open blog posts in Google Reader with 'v' key open new tabs but doesn't load pages (docShell: Not Remotable)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Fennec/4.0b2pre 20101029

When you try to open a blog post from Google Reader by using the 'v' key, a new tab opens but nothing gets loaded. Clicking the post title it works fine.

Steps:
1. Open about:config and add "keypress" to the dom.popup_allowed_events entry
2. Subscribe an RSS feed in Google Reader
3. Select a post from that feed
4. Tap on the title and wait for page loaded
5. Close tab and hit 'v'

After step 4 the new tab with the web page gets loaded but after step 5 an empty tab appears.

The following error is visible:

docShell: Not Remotable
Source: chrome://global/content/bindings/browser.xml

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Oh, and those steps work fine in Firefox.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Reduced Testcase

Reader does about 100 different fun things trying to open pages, and this is one of them. Guessing this is some sort of e10s bug...

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Testcase 2

Whoops. Forgot to set a type on this.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #3)
> Reader does about 100 different fun things trying to open pages, and this is
> one of them. Guessing this is some sort of e10s bug...

Is Fennec already using some sort of e10s on trunk?

Comment 6

[Aakash Desai [:aakashd]]

Henrik, yep. The chrome window is in a separate process as well as the content window.

Comment 7

[Wesley Johnston (:wesj)]

This has gotten me a bit worried. In the attached code we call:

  if(b=window.open("","FRAMENAME")) {
    b.document.write('stuff');
  }

which throws with the error "Permission denied to access property 'document'". As far as I know, sites can and will do this. However, if I modify the code slightly with a setTimeout (and loading a real page so that we don't load about:blank in a local tab):

  if(b=window.open("blank.html","FRAMENAME")) {
    setTimeout(function() { b.document.write('stuff') }, 0);
  }

now everything goes through fine. That makes me even more suspicious that we are hitting some sort of e10s problem. i.e. Are there async calls during the e10s new page creation that delay the creation of the new window slightly? mfinkle, do you know your way around this code and have any feedback about what is going on?

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Wesley, can you test if the patch in bug 648465 fixed this as well?

Comment 9

[Wesley Johnston (:wesj)]

Works great Blake! Thanks!

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Bug 648465 is fixed on trunk now.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Works fine now. Thanks for the fix.