608368 - Fennec FormHelper does not zoom to the correct position on all platforms [MeeGo]

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Jeremias Bosch (:jbos)]

+++ This bug was initially created as a clone of Bug #595233 +++

Since the landing of the last patch for bug 595233, the zooming code of the Form Helper does not zoom to the correct position on Meego.
The current patch revert mostly to the previous behavior but with a custom path for Meego nested into the visibleScreenArea getter and the observer.

The creator wanted to have a chance to test it on Meego but he didn't have any way to do it. The way he had checked the behavior was by using a custom _visibleScreenArea property while zooming.

This actually didn't work out and popper solution would be to revert the previous state since Meego depends on it.

Maybe it would be a solution to make the zooming way more platform depended and easier to customize to fit better into the rest of the systems design.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

An alternative idea is too try and get Meego to resize the main window when the VKB is opened. I know we discussed this before, and the idea didn't go anywhere. Maybe we should think about it again.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #0)
> +++ This bug was initially created as a clone of Bug #595233 +++
> 
> Since the landing of the last patch for bug 595233, the zooming code of the
> Form Helper does not zoom to the correct position on Meego.
> The current patch revert mostly to the previous behavior but with a custom path
> for Meego nested into the visibleScreenArea getter and the observer.

I think this is much much cleaner, and as I've said I tend to think we should handle the Meego case deeper in the code that hacking the Form Helper methods, like moving the _visibleScreenArea to Browser.

> The creator wanted to have a chance to test it on Meego but he didn't have any
> way to do it. The way he had checked the behavior was by using a custom
> _visibleScreenArea property while zooming.
> 
> This actually didn't work out and popper solution would be to revert the
> previous state since Meego depends on it.

What is not working exactly, coud you elaborate? Also patch to http://hg.mozilla.org/users/vnicolas_mozilla.com/keke/ would be greatly appreciated to help us understand how Meego is handling VKB.

In my opinion reverting again is _not_ the solution.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I think jbos is working on code to make this work better. We really need a solid plan for this on MeeGo.

Comment 4

[BMO Automation]

Closing all opened bug in a graveyard component