Closed
Bug 608507
Opened 14 years ago
Closed 14 years ago
some minor test cleanup
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b7
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
Attachments
(1 file)
12.05 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
Just a couple of more undeclared variables and an indentation fix I found.
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #487148 -
Flags: review?(dtownsend)
Assignee | ||
Updated•14 years ago
|
Severity: normal → trivial
Status: NEW → ASSIGNED
Updated•14 years ago
|
Attachment #487148 -
Flags: review?(dtownsend) → review+
Assignee | ||
Comment 2•14 years ago
|
||
Pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/2dba8f58b228
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
Comment 3•14 years ago
|
||
Robert, why some files are using 'let' while others got 'var'?
Assignee | ||
Comment 4•14 years ago
|
||
Before the patch some of the files were using var vs. let so to be consistent the patch uses var when the pre-existing test used var and used let when the pre-existing test used let. This made the patch consistent with the pre-existing code in the test.
Comment 5•14 years ago
|
||
That makes sense. Thanks for the explanation. Marking as verified fixed by check-in.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•