608569 - update to remote code for allowing tp4 runs successfully

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: adjust the file trasnfer for the tp4 logs from remote device -> host machine (1.0)

I have found a small corner case in my remote testing where when we transfer a large file, it appears that we get stuck in python trying to match a regex on the data from the transfered file.

I have added a 1 second sleep after the file transfer to resolve this.  Tested multiple times on android and n900 using remote testing for tp4 and it works great.

This still needs to run on staging, but the changes here are:
1) closing a file handle that wasn't done in 1 (of many) return paths in bcontroller.py
2) adding a time.sleep(1.0) to ffprocess_remote.py (will not affect staging).

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

this passes green on talos staging!

Comment 2

[alice nodelman [:alice] [:anode]]

Comment on attachment 487212 [details] [diff] [review]
adjust the file trasnfer for the tp4 logs from remote device -> host machine (1.0)

Small patches are scary!

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/build/talos/pushloghtml?changeset=ce9b0413fbf1