Findbar top border ought to be 1px solid ThreeDHighlight

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
Themes
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
seamonkey2.1b2
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.23 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
From bug 605622, comment 4:

"... ... Ideally the top border would actually be 1px solid ThreeDHighlight;
(same as a regular toolbar) (in all three windows) although the existing
-moz-border-top-colors makes this a little trickier."

(this is for win/linux)
(Assignee)

Comment 1

7 years ago
Created attachment 489238 [details] [diff] [review]
Fix top border

OK, so it would have been cleaner with the reversed colour sequence in win-/gnomestripe, then one could just had set a width of 1px...
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #489238 - Flags: superreview?(neil)
Attachment #489238 - Flags: review?(neil)
(Assignee)

Comment 2

7 years ago
(not tested on win/nix)

Comment 3

7 years ago
Comment on attachment 489238 [details] [diff] [review]
Fix top border

Nit: you don't actually need to duplicate the colour, as the border is only 1px.
Attachment #489238 - Flags: superreview?(neil)
Attachment #489238 - Flags: superreview+
Attachment #489238 - Flags: review?(neil)
Attachment #489238 - Flags: review+
(Assignee)

Comment 4

7 years ago
Pushed with nit addressed: http://hg.mozilla.org/comm-central/rev/5d48dda12543
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
You need to log in before you can comment on or make changes to this bug.