Closed
Bug 608623
Opened 14 years ago
Closed 14 years ago
Findbar top border ought to be 1px solid ThreeDHighlight
Categories
(SeaMonkey :: Themes, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b2
People
(Reporter: stefanh, Assigned: stefanh)
Details
Attachments
(1 file)
|
2.23 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
From bug 605622, comment 4: "... ... Ideally the top border would actually be 1px solid ThreeDHighlight; (same as a regular toolbar) (in all three windows) although the existing -moz-border-top-colors makes this a little trickier." (this is for win/linux)
|
Assignee | |
Comment 1•14 years ago
|
||
OK, so it would have been cleaner with the reversed colour sequence in win-/gnomestripe, then one could just had set a width of 1px...
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #489238 -
Flags: superreview?(neil)
Attachment #489238 -
Flags: review?(neil)
|
|
Assignee | |
Comment 2•14 years ago
|
||
(not tested on win/nix)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 489238 [details] [diff] [review] Fix top border Nit: you don't actually need to duplicate the colour, as the border is only 1px.
Attachment #489238 -
Flags: superreview?(neil)
Attachment #489238 -
Flags: superreview+
Attachment #489238 -
Flags: review?(neil)
Attachment #489238 -
Flags: review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Pushed with nit addressed: http://hg.mozilla.org/comm-central/rev/5d48dda12543
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
You need to log in
before you can comment on or make changes to this bug.
Description
•