Closed
Bug 608624
Opened 12 years ago
Closed 12 years ago
Clearing update notification launches fennec
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(fennec-)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
fennec | - | --- |
People
(Reporter: clouserw, Assigned: alexp)
Details
Attachments
(1 file)
6.44 KB,
patch
|
blassey
:
review+
dougt
:
approval2.0+
|
Details | Diff | Splinter Review |
To reproduce: 1) Using a nightly, wait until you are notified about an update. 2) go to the home screen (or an app that isn't fennec) 3) drag the notification bar down and press clear Results: Fennec launches, sometimes telling me it will update right then. Expected: Update is removed from list and I'm reminded again later
Updated•12 years ago
|
tracking-fennec: --- → ?
Updated•12 years ago
|
tracking-fennec: ? → 2.0-
Comment 1•12 years ago
|
||
Alex, seems like we can special case for clear not to launch fennec if we've already closed.
Assignee: nobody → alexp
Assignee | ||
Comment 2•12 years ago
|
||
(In reply to comment #1) > Alex, seems like we can special case for clear not to launch fennec if we've > already closed. Yes, I noticed this as well.
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•12 years ago
|
||
Weird, the code does check that, and only cancels the notification if Fennec is not running: http://mxr.mozilla.org/mozilla-central/source/embedding/android/NotificationHandler.java.in#89 But the main activity still starts.
Assignee | ||
Comment 4•12 years ago
|
||
Apparently the change of android:launchMode from "singleInstance" to "singleTask" in AndroidManifest.xml for the file picker (bug 569497) resulted in this behavior. Need to find a workaround.
Assignee | ||
Comment 5•12 years ago
|
||
Using BroadcastReceiver instead of Activity to handle notification clicks/deletions.
Assignee | ||
Updated•12 years ago
|
Attachment #494311 -
Flags: review?(blassey.bugs)
Updated•12 years ago
|
Attachment #494311 -
Flags: review?(blassey.bugs) → review+
Updated•12 years ago
|
Attachment #494311 -
Flags: approval2.0?
Updated•12 years ago
|
Attachment #494311 -
Flags: approval2.0? → approval2.0+
Comment 6•12 years ago
|
||
pushed http://hg.mozilla.org/mozilla-central/rev/0daedff288b7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 7•11 years ago
|
||
VERIFIED FIXED: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110608 Firefox/7.0a1 Fennec/7.0a1 Mozilla /5.0 (Android;Linux armv7l;rv:6.0a2) Gecko/20110607 Firefox/6.0a2 Fennec/6.0a2 Device: HTC Desire Z (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•