608624 - Clearing update notification launches fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, minor)

Description

[Wil Clouser [:clouserw]]

To reproduce: 

1) Using a nightly, wait until you are notified about an update.
2) go to the home screen (or an app that isn't fennec)
3) drag the notification bar down and press clear

Results:
Fennec launches, sometimes telling me it will update right then.

Expected:
Update is removed from list and I'm reminded again later

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Alex, seems like we can special case for clear not to launch fennec if we've already closed.

Comment 2

[Alex Pakhotin (:alexp)]

(In reply to comment #1)
> Alex, seems like we can special case for clear not to launch fennec if we've
> already closed.

Yes, I noticed this as well.

Comment 3

[Alex Pakhotin (:alexp)]

Weird, the code does check that, and only cancels the notification if Fennec is not running:
http://mxr.mozilla.org/mozilla-central/source/embedding/android/NotificationHandler.java.in#89

But the main activity still starts.

Comment 4

[Alex Pakhotin (:alexp)]

Apparently the change of android:launchMode from "singleInstance" to "singleTask" in AndroidManifest.xml for the file picker (bug 569497) resulted in this behavior.
Need to find a workaround.

Comment 5

[Alex Pakhotin (:alexp)]

Attachment: Fix

Using BroadcastReceiver instead of Activity to handle notification clicks/deletions.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/0daedff288b7

Comment 7

[Anna (Waverley)]

VERIFIED FIXED:

Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110608 Firefox/7.0a1 Fennec/7.0a1 

Mozilla /5.0 (Android;Linux armv7l;rv:6.0a2) Gecko/20110607 Firefox/6.0a2 Fennec/6.0a2 

Device: HTC Desire Z (Android 2.2)