60864 - Resized address toolbar does not collapse splitter properly

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[[e-mail]]

Build ID: 2000112015

Steps to reproduce problem:
1. Create a new message.
2. Collapse the address toolbar.
3. Expand the address toolbar.
4. Adjust the splitter.
5. Collapse the address toolbar.

Expected result: Address toolbar collapses properly both times.

Actual result: Splitter does not collapse with the address toolbar.

Comment 1

[Ninoschka Baca]

Build 2000-11-21-04: Win95
I am unable to reproduce the problem. It appears that the entire address area is
collapsed and I don't see the splitter. I've tried adjusting the splitter to
make it wider or narrow with the same results. Any other suggestions for
reproducing the problem?

Comment 2

[[e-mail]]

Attachment: Collapsed correctly

Comment 3

[[e-mail]]

Attachment: Collapsed incorrectly

Comment 4

[Ninoschka Baca]

Build 2000-11-28-09:Win96, Linux 6.0, Mac 9.04
I was able to reproduce this by adjusting the splitter that appears below the
'Formatting Toolbar'.

When I initially reported that I could not reproduce the problem I was adjusting
the splitter in the address area which is vertical to the Attachments area.

Comment 5

[[e-mail]]

Sorry, I didn't realize that there were two splitters...

Comment 6

[Ninoschka Baca]

No problem, I'm just glad that I could reproduce the problem :-)

Comment 7

[Jean-Francois Ducarroz]

reassign to varada

Comment 8

[varada]

Accepting bugs.

Comment 9

[[e-mail]]

Attachment: Proposed patch

Comment 10

[(not reading, please use [e-mail] instead)]

taking all of varada's bugs.

Comment 11

[Cavin Song]

Comment on attachment 89698 [details] [diff] [review]
Proposed patch

r=cavin.

Comment 12

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 13

[Wayne Mery (:wsmwk)]

resolved fixed?

Comment 14

[[e-mail]]

Attachment: Updated patch, version 1

We can alternatively fix this bug by moving the splitter inside the toolbar
(this has recently been made possible on trunk using resizeafter="grow").

Comment 15

[[e-mail]]

Attachment: Updated patch, version 2

Alternatively we could go for a revised version of my original patch; this patch also fixes an add/removeEventListener mismatch and hides the splitter when you collapse the addressing toolbar.

Comment 16

[Wayne Mery (:wsmwk)]

would this help with anything in Bug 290865 comment 3?

Comment 17

[[e-mail]]

(In reply to comment #16)
>would this help with anything in Bug 290865 comment 3?
No, it's not; this only applies to the use of the toolbargrippy.

Comment 18

[Karsten Düsterloh]

Comment on attachment 284934 [details] [diff] [review]
Updated patch, version 1

Having the splitter right of the grippy looks just weird.

Comment 19

[Karsten Düsterloh]

Comment on attachment 284935 [details] [diff] [review]
Updated patch, version 2

I prefer this approach, but is has issues: if you drag the splitter upwards, it will finally start to hide the subject row. If you drag on, it will even hide almost all of the address bar - but the listbox lines will shine through! And furthermore, if you let go of the splitter, it will jump back down to guarantee a minheight for the addressbar.
So, either the splitter should really hide _all_ stuff and remain where it was dragged to or it shouldn't be draggable that far...

Comment 20

[[e-mail]]

Attachment: Includes CSS fix for comment 19

The resizing issue appears to be due to the min-height in toolkit's toolbar.css

Comment 21

[[e-mail]]

Fix checked in.