If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add CAN_DRAW_IN_TITLEBAR since MENUBAR_CAN_AUTOHIDE is overloaded

RESOLVED FIXED in Firefox 4.0b8

Status

()

Firefox
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: dao, Assigned: WG9s)

Tracking

Trunk
Firefox 4.0b8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

7 years ago
The patch in bug 585370 does this, but it would be wise to do it separately because a) it makes sense regardless of that bug and b) it will make the patch in that bug less scary.
(Assignee)

Comment 1

7 years ago
Taking -> I will appropriately divide that patch up between both bugs.
Assignee: nobody → bill
(Assignee)

Comment 2

7 years ago
Created attachment 487458 [details] [diff] [review]
patch v1

I will ask for review once this passes my tests.
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

7 years ago
Blocks: 585370
(Assignee)

Comment 3

7 years ago
Created attachment 487501 [details] [diff] [review]
patch v2-fix nested ifdefs
Attachment #487458 - Attachment is obsolete: true
Attachment #487501 - Flags: review?(dao)
(Reporter)

Updated

7 years ago
Attachment #487501 - Flags: review?(dao) → review+
(Reporter)

Comment 4

7 years ago
Comment on attachment 487501 [details] [diff] [review]
patch v2-fix nested ifdefs

>--- a/browser/base/content/browser.js
>+++ b/browser/base/content/browser.js
>@@ -4720,22 +4720,26 @@ var TabsOnTop = {
> function updateAppButtonDisplay() {
>   var displayAppButton =
>     !gInPrintPreviewMode &&
>     window.menubar.visible &&
>     document.getElementById("toolbar-menubar").getAttribute("autohide") == "true";
> 
>   document.getElementById("titlebar").hidden = !displayAppButton;
> 
>+#ifdef CAN_DRAW_IN_TITLEBAR
>   if (displayAppButton)
>     document.documentElement.setAttribute("chromemargin", "0,-1,-1,-1");
>   else
>     document.documentElement.removeAttribute("chromemargin");
>-}
>-
>+#endif
>+}
>+#endif

document.getElementById("titlebar").hidden = !displayAppButton; should depend on CAN_DRAW_IN_TITLEBAR too.
(Assignee)

Comment 5

7 years ago
(In reply to comment #4) 
> document.getElementById("titlebar").hidden = !displayAppButton; should depend
> on CAN_DRAW_IN_TITLEBAR too.

Of course it should.
(Assignee)

Comment 6

7 years ago
Created attachment 487509 [details] [diff] [review]
patch v3;r=dao

With that fixed.

Carrying review forward.
Attachment #487501 - Attachment is obsolete: true
Attachment #487509 - Flags: approval2.0?
(Reporter)

Updated

7 years ago
Attachment #487509 - Flags: approval2.0?
(Reporter)

Comment 7

7 years ago
http://hg.mozilla.org/mozilla-central/rev/7ca426c55d9b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
You need to log in before you can comment on or make changes to this bug.