608760 - Tamarin tests with versioning checks not exported into ATS

Status: RESOLVED FIXED

(Tamarin Graveyard :: Tools, defect, P4)

Description

[Chris Peyer]

The flash player team is still coming up with the right way to test versioned bug fixes in the ATS.  Until that has been determined, Tamarin versioning tests must be skipped on ATS export.

Comment 1

[Trevor Baker]

Has the situation changed yet?

Comment 2

[Trevor Baker]

Ping...

Comment 3

[Chris Peyer]

We will be able to do this when

https://bugs.adobe.com/jira/browse/ASC-4232

is fixed.  This will also require changes to the runtests.py code that generates swfs.  We will need to check for the use of .avm_args files that have USES_SWFVERSION and output a seperate swf for every available version.  The use of avmplus.System.swfVersion will have to be replaced by flash.display.LoaderInfo.swfVersion so we will also need to modify all of the versioned tests.

Comment 4

[Chris Peyer]

Attachment: Update vector test to be ATS compatible

I had to update this test for the ATS as it was not deleting a prototype property it was setting.  I then realized that this test actually now uses some versioning checks and so updated the test to be versioning compatible in the ATS.  This is probably a good template to see how to update the other tamarin versioning tests (though we may want to move the swfVersion logic into shell.as).

Comment 5

[Tamarin Bot]

changeset: 6247:cbb91ee4ba35
user:      Chris Peyer <[e-mail]>
summary:   Bug 608760: Update test to be ATS compatible (r=jsudduth)

http://hg.mozilla.org/tamarin-redux/rev/cbb91ee4ba35

Comment 6

[Chris Peyer]

Attachment: Add ability to export multiple versioned swfs to the ats

This patch fixes up the current versioning tests to be compatible with this bug, as well as adds .avm_args files for tests that use versioning but were missing the USES_SWFVERSION directive.

When creating ATS tests for versioned tests, a separate swf will be created for every available swfversion and will be named with _vX where X is the version number.

Also has some code cleanup and removal of ATS generation code in compile_test as all ATS gen happens via compileWithAsh.

Comment 7

[Brent Baker]

Comment on attachment 530414 [details] [diff] [review]
Add ability to export multiple versioned swfs to the ats

Looks good, but appears that a change snuck in here:
mmgc/pauseForGCIfCollectionImminent.as

I have a feeling this should not be part of this patch.

Comment 8

[Tamarin Bot]

changeset: 6277:8cfb04474edc
user:      Chris Peyer <[e-mail]>
summary:   Bug 608760: Add ability to export versioned tests to ATS swfs (note that this requires asc.jar 4:554f21f659dd from asc-main repo) (r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/8cfb04474edc

Comment 9

[Brent Baker]

tamarin-redux-serrano brbaker$ hg log -r f7be25bb83c3
changeset:   6267:f7be25bb83c3
user:        Chris Peyer <[e-mail]>
date:        Fri May 06 08:47:47 2011 -0700
summary:     Bug 608760: Add ability to export versioned tests to ATS swfs (note that this requires asc.jar 4:554f21f659dd from asc-main repo) (r=brbaker)