JM: inline fast path for string concatenation

RESOLVED WONTFIX

Status

()

Core
JavaScript Engine
RESOLVED WONTFIX
7 years ago
5 years ago

People

(Reporter: luke, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
(Even after the infallible-malloc hack in bug 608776) callgrind shows 30% of date-format-xparb is spent below stubs::Add.  8% is spent in stubs::Add itself.  With bug 608776 taking the malloc out of js_ConcatStrings (usually), we should be able to write a stub-call-free fast path which either creates a rope node or fills a short string.  Because xparb uses String objects (costing, even after bug 603017, 5% in js::DefaultValue), this fast path should also include an IC for 'toString' on objects.
(Reporter)

Updated

7 years ago
Depends on: 608776
Blocks: 578133

Updated

7 years ago
Blocks: 609212
I think bug 609440 is going ahead instead of bug 608776.  The net effect w.r.t. this bug should be the same, though.
Depends on: 609440
No longer depends on: 608776
(Reporter)

Comment 2

7 years ago
Throwing back in the pool.
Assignee: luke → general
(Reporter)

Updated

7 years ago
Whiteboard: [good first bug]
(Reporter)

Comment 3

7 years ago
un-good-first-bugging.  With IonMonkey development full steam, this should either be WONTFIX'd or re-targeted towards IonMonkey.
Whiteboard: [good first bug]
(Reporter)

Comment 4

5 years ago
Too late, JM was removed.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.