Seed random number generator with increased variability

RESOLVED FIXED

Status

Tamarin
Virtual Machine
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Rick Reitmaier, Assigned: Rick Reitmaier)

Tracking

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

7 years ago
Provide an additional interface for MathUtils to be seeded by something other than VMPI_getTime()
Depends on: 596056
(Assignee)

Updated

7 years ago
Assignee: nobody → rreitmai
Status: NEW → ASSIGNED
(Assignee)

Comment 2

7 years ago
Created attachment 490012 [details] [diff] [review]
use getPerformanceCounter() for seeding pRNG

whitespace cleanup in CodegenLIR along with MathUtils change wherein VMPI_getPerformanceCounter() is used rather than VMPI_getTime().

Also cleaned up inaccurate comments stating the pRNG generates a repeatable sequence for each construction; it does not, and has never done so since the inception of tamarin.

Other uses in the player appear to have little interest in how the seeding takes place, so this change will only be for the better.
Attachment #490012 - Flags: review?(stejohns)

Updated

7 years ago
Attachment #490012 - Flags: review?(stejohns) → review+

Comment 3

7 years ago
changeset: 5562:d0edc8e15231
user:      Rick Reitmaier <rreitmai>
date:      Thu Nov 11 18:53:00 2010 -0800
summary:   Bug 608798 - Seed random number generator with increased variability (r=stejohns)

http://hg.mozilla.org/tamarin-redux/rev/d0edc8e15231
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.