Closed Bug 608807 Opened 11 years ago Closed 11 years ago

Addon UI: Setup dialog too small in l10n builds

Categories

(Firefox :: Sync, defect)

x86
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: tracy, Assigned: philikon)

Details

Attachments

(2 files)

Attached image overflowed setup dialog
Seen on 3.6.12 with "it" on Mac 

See screenshot.

The setup dialog is too small for the content of the Italian locale strings.
This pushes the continue button nearly completely off screen.
requesting blocking.  

I don't know how many locales this affects.  But if any of them are worse than the it locale (i.e. the continue button completely pushed off screen) this should probably block.
Flags: blocking-fx-sync1.5?
Attached patch v1Splinter Review
Make the header label wrap if it's too long.

Not an awesome fix, but this avoids having to ship our own XBL just for this change. It's marginally more involved than adding a crop="end" attribute to the label, but then it retains the full text.
Assignee: nobody → philipp
Attachment #487523 - Flags: review?(mconnor)
Comment on attachment 487523 [details] [diff] [review]
v1

ew.  please commit to branch and trunk, bump branch version, and tag for 1.5.1b3
Attachment #487523 - Flags: review?(mconnor) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
As seen on Italian 3.6.12 with 1.5.1b3 installed, all content now available with scroll bar.  And buttons aren't pushed out of view.
Status: RESOLVED → VERIFIED
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Summary: Setup dialog too small in l10n builds → Addon UI: Setup dialog too small in l10n builds
Looks like this was done, no?

If not, we're not going to do any more...
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Flags: blocking-fx-sync1.5?
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.